Skip to content

ci: retire redundant taptests workflows — callers (groups/taptests/asan/ssl/old) - #5870

Merged
renecannao merged 2 commits into
v3.0from
ci/retire-redundant-taptests-callers
Jul 7, 2026
Merged

renecannao merged 2 commits into
v3.0from
ci/retire-redundant-taptests-callers

Conversation

@renecannao

@renecannao renecannao commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

Part of finishing the migration off the private jenkins-build-scripts repo + cross-org GH_TOKEN_PROXYSQL PAT.

taptests-groups runs the full tests TAP matrix through the legacy jenkins harness. Verified all 392 test binaries it runs are already assigned to active modern infra-groups in test/tap/groups/groups.json (legacy-g*, mysql84-g*, mysql84-gr-, mariadb10-galera-, …) that run via the in-repo test/infra harness — 392/392 covered, 0 unique. Legacy duplicate; retiring it loses no coverage.

Deletes callers CI-taptests.yml, CI-taptests-groups.yml. Companion GH-Actions PR removes the reusables — merge this one first so no caller references a deleted reusable.

Part of a phased migration; taptests-asan/-ssl (unique ASAN/SSL modes), repltests/shuntest (test code lives in the private repo — to be vendored), and the disabled 3p-* are handled separately.

🤖 Generated with Claude Code

https://claude.ai/code/session_01C21CuatwQ3CtFr62A6M4gU

Summary by CodeRabbit

  • Chores
    • Removed outdated CI workflow definitions related to tap tests (including groups, ASAN, and SSL) from the repository, including their trigger wiring and delegation to shared reusable workflows.

Companion to the GH-Actions reusable removal. taptests-groups is a legacy
duplicate: all 392 tests it runs are already covered by active modern
infra-groups (legacy-g*, mysql84-g*, galera, gr, ...) via the in-repo
test/infra harness, so removing it loses no coverage and drops a consumer
of the cross-org GH_TOKEN_PROXYSQL PAT. Merge this (callers) before the
GH-Actions PR that deletes the reusables.

Claude-Session: https://claude.ai/code/session_01C21CuatwQ3CtFr62A6M4gU
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 58cb0d5e-19da-4ee1-be56-fff7057917f7

📥 Commits

Reviewing files that changed from the base of the PR and between 1eb8b97 and d02bd52.

📒 Files selected for processing (2)
  • .github/workflows/CI-taptests-asan.yml
  • .github/workflows/CI-taptests-ssl.yml
💤 Files with no reviewable changes (2)
  • .github/workflows/CI-taptests-asan.yml
  • .github/workflows/CI-taptests-ssl.yml

📝 Walkthrough

Walkthrough

This pull request removes three GitHub Actions workflow files for taptests, deleting their dispatch and workflow_run triggers, concurrency settings, permissions, and reusable-workflow jobs.

Changes

Cohort / File(s) Summary
Workflow deletions
.github/workflows/CI-taptests-groups.yml, .github/workflows/CI-taptests.yml, .github/workflows/CI-taptests-asan.yml, .github/workflows/CI-taptests-ssl.yml
Removes the taptests workflow wrappers and their trigger, concurrency, permissions, and reusable-workflow delegation configuration.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • sysown/proxysql#5590: Changes the same taptests workflow trigger wiring that this PR removes.
  • sysown/proxysql#5595: Updates the same CI-taptests*.yml workflows that are deleted here.
  • sysown/proxysql#5604: Modifies GitHub Actions caller workflows by neutralizing workflow_run trigger wiring in a similar CI area.

Poem

I’m a rabbit with a broom and a grin,
Hop-hop, the old workflows tumble in.
No triggers left, just tidy air,
YAML burrows now feel rare,
Soft whiskers wave: cleanup wins! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: retiring redundant taptests workflow callers, including groups, taptests, asan, and ssl.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/retire-redundant-taptests-callers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Companion to the GH-Actions reusable removal. Both disabled_manually; retiring
removes the remaining taptests* consumers of GH_TOKEN_PROXYSQL. No active coverage
lost (unit-ASAN + SSL-specific tests already run in modern CI). Full-suite ASAN/SSL
modes are a separate gap noted in the reusable-PR commit.

Claude-Session: https://claude.ai/code/session_01C21CuatwQ3CtFr62A6M4gU
@renecannao renecannao changed the title ci: retire redundant taptests workflows (callers) ci: retire redundant taptests workflows — callers (groups/taptests/asan/ssl/old) Jul 6, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@renecannao
renecannao merged commit 2b2d3d1 into v3.0 Jul 7, 2026
4 checks passed
@renecannao
renecannao deleted the ci/retire-redundant-taptests-callers branch August 16, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant