Repository navigation
ci: retire redundant taptests workflows — callers (groups/taptests/asan/ssl/old) - #5870
Conversation
Companion to the GH-Actions reusable removal. taptests-groups is a legacy duplicate: all 392 tests it runs are already covered by active modern infra-groups (legacy-g*, mysql84-g*, galera, gr, ...) via the in-repo test/infra harness, so removing it loses no coverage and drops a consumer of the cross-org GH_TOKEN_PROXYSQL PAT. Merge this (callers) before the GH-Actions PR that deletes the reusables. Claude-Session: https://claude.ai/code/session_01C21CuatwQ3CtFr62A6M4gU
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis pull request removes three GitHub Actions workflow files for taptests, deleting their dispatch and workflow_run triggers, concurrency settings, permissions, and reusable-workflow jobs. Changes
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Companion to the GH-Actions reusable removal. Both disabled_manually; retiring removes the remaining taptests* consumers of GH_TOKEN_PROXYSQL. No active coverage lost (unit-ASAN + SSL-specific tests already run in modern CI). Full-suite ASAN/SSL modes are a separate gap noted in the reusable-PR commit. Claude-Session: https://claude.ai/code/session_01C21CuatwQ3CtFr62A6M4gU
|



Part of finishing the migration off the private
jenkins-build-scriptsrepo + cross-orgGH_TOKEN_PROXYSQLPAT.taptests-groupsruns the fulltestsTAP matrix through the legacy jenkins harness. Verified all 392 test binaries it runs are already assigned to active modern infra-groups intest/tap/groups/groups.json(legacy-g*, mysql84-g*, mysql84-gr-, mariadb10-galera-, …) that run via the in-repotest/infraharness — 392/392 covered, 0 unique. Legacy duplicate; retiring it loses no coverage.Deletes callers
CI-taptests.yml,CI-taptests-groups.yml. Companion GH-Actions PR removes the reusables — merge this one first so no caller references a deleted reusable.Part of a phased migration;
taptests-asan/-ssl(unique ASAN/SSL modes),repltests/shuntest(test code lives in the private repo — to be vendored), and the disabled3p-*are handled separately.🤖 Generated with Claude Code
https://claude.ai/code/session_01C21CuatwQ3CtFr62A6M4gU
Summary by CodeRabbit