Request for comments:
The OpenMapTiles schema states
If there is no more general class for the subclass this field will contain the same value as subclass
To give an example: amenity=parking is currently rendered as class=amenity and subclass=parking. As I understand the schema, it should be class=parking and subclass=parking
The key amenity is assigned as class value here:
|
class = poiClasses[v] or k |
POI Tags like amenity, historic, leisure, tourism, waterway should not be a class. However, the following tags are classes in the OpenMapTiles schema:
-- list of OSM keys that can be used for POI classification
poiTagsAsClass = { aerialway = "aerialway",
office = "office",
railway = "railway",
shop = "shop"}
}They should be used as class but the other keys should not, therefore at the end of the line k is changed to v (which is then also the value of the subclass). Suggestion:
class = poiClasses[v] or poiTagsAsClass[k] or v
Request for comments:
The OpenMapTiles schema states
To give an example:
amenity=parkingis currently rendered asclass=amenityandsubclass=parking. As I understand the schema, it should beclass=parkingandsubclass=parkingThe key
amenityis assigned as class value here:tilemaker/resources/process-openmaptiles.lua
Line 849 in 0ebc1d7
POI Tags like
amenity, historic, leisure, tourism, waterwayshould not be a class. However, the following tags are classes in the OpenMapTiles schema:They should be used as class but the other keys should not, therefore at the end of the line k is changed to v (which is then also the value of the subclass). Suggestion: