Repository navigation
fix(stryker-js-vitest-runner): require Node 24 and document the V8 JSON.parse key bug - #309
Merged
Merged
Conversation
…ON.parse key bug The runner calls RegExp.escape (VitestRunner.service.ts:167, VitestRuntime.blueprint.ts:100), which Node 22 lacks: on Node 22.23.3, kill-first-ordering.integration.test.ts fails its three testFilter scenarios with status 'error' and passes 4/4 on Node 24.21.0. Its engines floor now matches stryker-js (>=24.13.1). The intermittent ∀x_CountedReportJson_=x failures come from the V8 escaped-key transition bug in Node 24 (nodejs/node#63785; backport nodejs/node#66542 unmerged), not from the schema. The stryker-js README gains a Known issues entry with the condition for removing it. No CI pin, law, generator, seed or parser change.
…correct the README and solution docs Narrowing engines.node is a break, so per BREAK-1 the runner changeset bumps major. The runner README's prerequisite now says Node.js >=24.13.1, matching engines. Two solution docs about nodejs/node#63785 are corrected: Node 22 (V8 12.4) is not affected, and the propertySeed pin they describe is gone (#109, #110); the current state is the stryker-js README known issue, removed once a Node 24 release carries the nodejs/node#66542 backport.
The sweep (2026-08-21) found V8 13.6 (Node 24.19.0) and V8 14.6 (Node 26.7.0) affected and V8 12.4 (Node 22.23.2) correct, bracketing the regression between 12.4 and 13.6. Nothing supported the earlier 'V8 12.8 and later'. A 2026-10-05 comment reports it on 24.21.0 and 26.10.0.
ryanleecode
approved these changes
Oct 12, 2026
ryanleecode
left a comment
Contributor
There was a problem hiding this comment.
Verified at 3aec05e: all checks green except the bench typescript-checker leg (fails on every PR); 0 open threads; diff is engines floor + READMEs + changesets + solution docs, no skips/disables/pins. Review dispositions in body (major per BREAK-1 accepted, README floor accepted, two risks ruled with grep evidence). Review lenses ran on omp's reviewer routing (MiniMax M3.1, omp-config.yml:42-53; generic task/reviewer agents disabled), so the cross-model pass is present. Main delta since CI: #293, test-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The intermittent
∀x_CountedReportJson_=xand∀x_KillMatrixReportJson_=xfailures (one of them turned #294'scheckred) are not a schema defect. On Node 24, after V8'sJSON.parsehas read an object key that ends in an escaped backslash, a later escaped key in the same position can decode to that cached key. This is nodejs/node#63785. V8 fixed it in93cd21e825, and the Node 24 backport nodejs/node#66542 is still unmerged. Node 22 (V8 12.4) is not affected.The ruling for this flake is to document the bug and declare the real runtime floor. There is no CI pin, no schema or generator change, no seed pin, no custom parser and no pinned regression test.
Changes
packages/stryker-js/README.md: a new Known issues section. On Node 24.x (and 26.x up to at least 26.7.0),JSON.parsecan return the wrong key in a long-lived process, which affects reading report JSON in the same process. It cites #63785 and #66542 and says to re-check and remove the entry once a Node 24 release carries the #66542 backport.packages/stryker-js-vitest-runner/package.json:engines.nodechanges from>=22.18.0to>=24.13.1, the same floor as@systemfsoftware/stryker-js. The runner calls the built-inRegExp.escape, which Node 22 lacks, so a mutant run that filters to named tests ended in an error on Node 22.packages/stryker-js-vitest-runner/README.md: the prerequisite now saysNode.js >=24.13.1, matchingengines.majorfor@systemfsoftware/stryker-js-vitest-runner(BREAK-1: narrowingenginesis a break, so 9.0.2 becomes 10.0.0), andpatchfor@systemfsoftware/stryker-js(README only).stream-schema-must-not-carry-json-rest-records.md: states what the #63785 version sweep (2026-08-21) measured. V8 13.6 and 14.6 (Node 24 and 26) are affected, V8 12.4 (Node 22) is not, and the regression lies somewhere between 12.4 and 13.6. A 2026-10-05 comment also reports it on Node 24.21.0 and 26.10.0. A local probe on Node 22.23.3 also returns the right key.v8-json-parse-key-corruption-schema-laws.md: no property seed is pinned any more (the hook left in chore(repo): move to the latest @systemfsoftware packages and the @systemfsoftware/vitest fork #109 and the pin in fix(repo): repair the vm runner and config subpath after 11.0.0 #110). A new Current State section points at the README known issue and gives the removal condition (a Node 24 release with the #66542 backport).Review (report-only
ce-code-reviewon2829670f6, rulings applied)patch, but BREAK-1 (AGENTS.md) ships a break asmajor.major.Node.js >=22.18.0.>=24.13.1.stryker-js, whose README carries it.stryker-js-plugin-runtimeand thestryker-js-typescript-checkerREADME still claim>=22.18.0.git grep -n 'RegExp.escape' -- 'packages/*/src'finds it only instryker-js-vitest-runner(2 call sites).Verification
pnpm install --frozen-lockfilepasses with no lockfile change.dprint checkis clean.Placement (OP13b)
This PR is off
mainby ruling. These open PRs also change one of its files, and whichever lands second takes the merge:fix/manifest-document-keys:docs/solutions/test-failures/stream-schema-must-not-carry-json-rest-records.mdfix/gate-merged-break,stryker/verdict-store,stryker/verdict-store-ci:packages/stryker-js/README.md