Repository navigation
Conversation
… waiting forever (t3dotgg#8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8.
Each
sol-loopround starts withdelegate_taskinmode: "async"and then says "Wait for the notice. Do not poll." The notice only comes when the child's run ends, and nothing sets a deadline, so "Timeout, error, or no reply is not approval" can never trigger. When a Sol child keeps compacting after it has printed its verdict, the parent waits forever — the reporter saw 9 to 10 hours, five times in one night.This bounds every round, using tools T3 already has (verified against T3 Code's own orchestrator docs and source:
delegate_taskacceptsmode: "async" | "wait"andtimeoutMs, andt3_thread_read,t3_thread_wait,task_cancelall exist):delegate_taskinmode: "wait",timeoutMs: 600000(10 min), savingtaskIdandchildThreadId.waitthat times out leaves the child running:t3_thread_readits thread. Once aVERDICT:line appears,task_cancelthe child and use that verdict, because the child's turn may never end. Otherwiset3_thread_wait10 more minutes and read again.No test suite exists in this repo; verification is the tool-surface check above plus a re-read of the edited section for consistency with the rest of the skill (the "Do not edit scoped files while review runs" and "Timeout, error, or no reply is not approval" rules are unchanged, and section 4's "Use a fresh
delegate_task" inherits the new mode since section 2 says "every round").