fix: correct :size=W,H argument order in URL params (#349)#414
Open
jacalata wants to merge 2 commits into
Open
fix: correct :size=W,H argument order in URL params (#349)#414jacalata wants to merge 2 commits into
jacalata wants to merge 2 commits into
Conversation
:size=W,H was being parsed as height,width since commit ae9f929. Also guard against partial state by converting both dimensions before assigning either, and replace deprecated logger.warn with logger.warning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…path, clearer values Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getwith:sizehas order of arguments switched from tabcmd 1 #349getwith:size=800,600in the URL was settingviz_height=800, viz_width=600(transposed from tabcmd 1 behavior)width, height = setting_val.split(",")(washeight, width)viz_widthandviz_heightasNone(no partial state)logger.warn(...)withlogger.warning(...)— the old call also had a latent bug where the exception argument was never rendered into the log line1920,1080) make swap direction self-evident; adds test for invalid second dimension leaving both unset; adds integration test throughapply_values_from_url_paramsTest plan
python -m pytest tests/commands/test_datasources_and_workbooks_command.py -v— 25 tests passtabcmd get "workbook/view?:size=1920,1080" -f out.pngproduces a 1920×1080 image🤖 Generated with Claude Code