Skip to content

fix: correct :size=W,H argument order in URL params (#349)#414

Open
jacalata wants to merge 2 commits into
developmentfrom
jac/fix-349-get-size-arg-order
Open

fix: correct :size=W,H argument order in URL params (#349)#414
jacalata wants to merge 2 commits into
developmentfrom
jac/fix-349-get-size-arg-order

Conversation

@jacalata

@jacalata jacalata commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixes tabcmd get with :size has order of arguments switched from tabcmd 1 #349
  • get with :size=800,600 in the URL was setting viz_height=800, viz_width=600 (transposed from tabcmd 1 behavior)
  • Swaps the unpacking: width, height = setting_val.split(",") (was height, width)
  • Converts both dimensions to int before assigning either, so a parse failure on either value leaves both viz_width and viz_height as None (no partial state)
  • Replaces deprecated logger.warn(...) with logger.warning(...) — the old call also had a latent bug where the exception argument was never rendered into the log line
  • Strengthens tests: asymmetric values (1920,1080) make swap direction self-evident; adds test for invalid second dimension leaving both unset; adds integration test through apply_values_from_url_params

Test plan

  • python -m pytest tests/commands/test_datasources_and_workbooks_command.py -v — 25 tests pass
  • tabcmd get "workbook/view?:size=1920,1080" -f out.png produces a 1920×1080 image

🤖 Generated with Claude Code

jacalata and others added 2 commits July 1, 2026 18:17
:size=W,H was being parsed as height,width since commit ae9f929.
Also guard against partial state by converting both dimensions before
assigning either, and replace deprecated logger.warn with logger.warning.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…path, clearer values

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py101010 0%
   tabcmd.py151515 0%
   version.py622 67%
tabcmd/commands
   commands.py101010 0%
   constants.py771818 77%
   server.py1351818 87%
tabcmd/commands/auth
   session.py3814646 88%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1571818 89%
   datasources_workbooks_views_url_parser.py14255 96%
   delete_command.py601616 73%
   export_command.py1202525 79%
   get_url_command.py1274747 63%
   publish_command.py1232828 77%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481010 79%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2722 93%
   edit_site_command.py3822 95%
   list_command.py771212 84%
   list_sites_command.py2922 93%
tabcmd/commands/user
   add_users_command.py2955 83%
   create_site_users.py581111 81%
   create_users_command.py601010 83%
   delete_site_users_command.py4355 88%
   user_data.py2213131 86%
tabcmd/execution
   _version.py222 0%
   global_options.py12588 94%
   localize.py661111 83%
   logger_config.py5166 88%
   tabcmd_controller.py4277 83%
TOTAL283543985% 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant