Repository navigation
Check the writes in the CDX test server, for errcheck - #107
Merged
Merged
Conversation
#106 merged one commit short of this, so lint is red on main. The two writes in the fake CDX server's handler had unchecked returns.
13 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red on lint. #106 merged at the commit before this two line fix landed on the branch, so the fake CDX server's handler still has two uncheckedfmt.Fprint*returns:golangci-lint run ./...reports 0 issues with this, and the CDX tests still pass. Nothing else changes.