Repository navigation
fix(server): upstream's ProviderTurnStartService tests no longer need the fork's InlineShellStore - #75
Merged
tannerpolley merged 1 commit intoOct 21, 2026
Conversation
Use Effect.serviceOption for the fork-only InlineShellStore and start provider turns directly when it is absent. Preserve inline shell delivery when production supplies the store. Closes #70 Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
tannerpolley
deleted the
issue-70-upstreams-new-providerturnstartservice
branch
October 21, 2026 00:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream's new
ProviderTurnStartService.memory.test.ts(upstream pingdotgg#22117, from today's sync) failed all 5 cases onmain. The fork's version of the service hard-required the fork'sInlineShellStore, which upstream's test layer doesn't provide.ProviderTurnStartServicenow readsInlineShellStorethroughEffect.serviceOption, and it's no longer a required layer dependency. Without it, the original provider session is used unchanged. With it, inline-shell delivery and its error mapping are exactly as before.runtimeLayer.tsstill providesInlineShellStore.layerdirectly to this service.Other upstream constructors with hard fork-only dependencies, all already provided in their test layers:
ProviderTurnControlServiceneedsInlineShellStore,ProjectServiceneedsSidebarLayoutService, andWorktreeMcpServiceneedsThreadWorkspaceService.Closes #70
🤖 Generated with Claude Code (implemented by GPT-6.1 Sol via T3 Code; orchestrated by Claude Opus 5.5)