allow for custom optimization strategies #368

Activity

1. ahal commented on Nov 29, 2023

   

   ahal

   on Nov 29, 2023

   Contributor

   More actions

   I think rather than copy Gecko here, I'd rather the schema be provided as an argument to the @register_strategy decorator. That way the schema definition lives next to the thing that requires it and we don't need to call extra functions in the registration.
2. ahal commented on Nov 29, 2023

   

   ahal

   on Nov 29, 2023

   Contributor

   More actions

   See the group_by decorator for an example of this:
   

   taskgraph/src/taskgraph/util/dependencies.py

   Line 38 in 931ab6f

   @group_by("attribute", schema=Schema(str))
3. bhearsum commented on Nov 29, 2023

   

   bhearsum

   on Nov 29, 2023

   ContributorAuthor

   More actions

   I think rather than copy Gecko here, I'd rather the schema be provided as an argument to the @register_strategy decorator. That way the schema definition lives next to the thing that requires it and we don't need to call extra functions in the registration.

   Sounds very reasonable to me!
4. Eijebong

   added 2 commits that reference this issue on Dec 24, 2025

   Register the optimization schema with `register_strategy`

   ...

   This issue will close once commit d5c2724 is merged into the 'main' branch.

   d5c2724

   Register the optimization schema with `register_strategy`

   ...

   This issue will close once commit cf8e2f6 is merged into the 'main' branch.

   cf8e2f6