Repository navigation
feat: install cumulative updates for SQL Server 2025 - #297
Merged
dhensby merged 3 commits intoOct 12, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The configuration, tests, documentation, and generated bundle consistently implement SQL Server 2025 cumulative updates.
0 open findings
What changed in this PR
Adds cumulative-update support for SQL Server 2025, including the default latest version.
Changes:
- Configures the official SQL Server 2025 update page.
- Adds SSEI update-installation and version-registry tests.
- Updates documentation and generated artifacts.
| File | Description |
|---|---|
src/versions.ts |
Adds the 2025 cumulative-update URL. |
test/versions.ts |
Verifies supported update configurations. |
test/install.ts |
Tests updates during SSEI installation. |
README.md |
Documents update-supported versions. |
lib/main/index.js |
Rebuilds the action bundle. |
lib/main/index.js.map |
Updates the bundle source map. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dhensby
force-pushed
the
feat/sql-2025-cumulative-updates
branch
3 times, most recently
from
October 12, 2026 08:57
3689401 to
0f775c0
Compare
Setup exits with 3010 when it succeeds but wants a reboot, which a runner can't do mid-job. Previously @actions/exec rejected that as a failure even though the instance was installed. Log a warning instead and continue. Because the instance may genuinely need that reboot, a database that never becomes ready after a 3010 now fails the action (when wait-for-ready is enabled) rather than only warning. Any other non-zero exit code still fails the action. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Microsoft now publishes cumulative updates for SQL Server 2025, so configure its update URL. Because `latest` resolves to 2025, users with `install-updates: true` on the default version previously got no cumulative update at all; they now get the latest CU applied during setup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dhensby
force-pushed
the
feat/sql-2025-cumulative-updates
branch
from
October 12, 2026 09:33
0f775c0 to
32ab948
Compare
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft now publishes cumulative updates for SQL Server 2025 at https://www.microsoft.com/en-us/download/details.aspx?id=108788, so this adds it as the 2025
updateUrland drops the stale "updateUrl can be added once…" comment.Because
latest(the defaultsqlserver-version) resolves to 2025, anyone usinginstall-updates: trueon the default version has been getting no CU at all. With this change they get the latest CU (currently KB5122048, 17.0.5005.3) applied during setup. That's a change in what users get by default, hencefeat:.Builds on #295 (the reworked CU page resolver). I ran that resolver against the live 2025 page: it resolves to exactly one x64 installer,
https://download.microsoft.com/download/10a21237-8b59-4fcd-b878-bfe8fcabdc7a/SQLServer2025-KB5122048-x64.exe.Setup exit code 3010
With the CU applied, setup on
windows-2025runners finishes withFinal result: Passed but reboot requiredand exit code 3010. Patch Level is 17.0.5005.3, so the update itself installed fine.@actions/exectreated that as a failure. A separatefix:commit now treats 3010 as success with a warning. Any other non-zero exit code still fails the action. Withwait-for-readyon, a database that doesn't come up after a 3010 fails the action instead of only warning, so a reboot-dependent install can't pass. This applies to every version, not just 2025.Other tools handle 3010 the same way: Chocolatey's SQL Server packages, dbatools and actions/runner-images all treat
0/3010as success./SkipRules=RebootRequiredCheckwouldn't help, because that rule runs before install and passed here. Our logs don't name the component that asked for the reboot. The leading suspect is the LocalDB 17 that comes pre-installed on thewindows-2025image only, which the CU replaces.Changes
src/versions.ts: 2025 entry gets itsupdateUrltest/versions.ts: asserts an update URL is configured for 2016 through 2025test/install.ts: covers an SSEI install withinstall-updates: true(passes/UPDATEENABLED=1and/UpdateSource). Nothing tested that combination beforeREADME.md: says which versions get cumulative updatessrc/install.ts: setup exit code 3010 logs a warning and continues, and if the database isn't ready afterwards the action fails. Other non-zero codes throw. Tests cover each path, and README + copilot-instructions document itlib/: rebuiltVerification
npm run lint:fix,npm test(155 passing),npm run buildCI
runaction(run 37911525309, all green).@@VERSIONcomes from the readiness probe:@@VERSION2025 (RTM-CU9) (KB5122048) - 17.0.5005.32025 (RTM-CU9) (KB5122048) - 17.0.5005.32025 (RTM-CU9) (KB5122048) - 17.0.5005.32025 (RTM-CU9) (KB5122048) - 17.0.5005.3So 2025 setup extracted by SSEI accepts
/UPDATEENABLED=1 /UpdateSource, and the instance runs the CU without a reboot.🤖 Generated with Claude Code