Fixes value for storage.oci.repository by PuneetPunamiya · Pull Request #974 · tektoncd/chains

PuneetPunamiya · 2023-10-27T17:03:20Z

Previously while providing repo url value for storage oci repository, chains controller was giving an error as
a digest must contain exactly one '@' separator (e.g. registry/repository@digest)
because, it was not able to add digest and repo name
Hence this patch fixes it, by formatting the value provided by the user and thus storing the
attestations/signatures in the provide location

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2023-10-27T17:08:58Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/oci/legacy.go	37.7%	37.1%	-0.7

lcarva

I'm not sure how this fixes the issue from the description. A unit test might be a good idea to express it.

PuneetPunamiya · 2023-11-02T13:03:09Z

I'm not sure how this fixes the issue from the description. A unit test might be a good idea to express it.

Yeah will be adding it 👍🏻

tekton-robot · 2023-11-09T15:23:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/oci/legacy.go	37.7%	40.5%	2.8

PuneetPunamiya · 2023-11-09T15:34:07Z

I'm not sure how this fixes the issue from the description. A unit test might be a good idea to express it.

Yeah will be adding it 👍🏻

I have added the test cases. PTAL

tekton-robot · 2023-11-09T15:36:38Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/oci/legacy.go	37.7%	40.0%	2.3

tekton-robot · 2023-11-10T07:04:43Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/oci/legacy.go	37.7%	40.0%	2.3

tekton-robot · 2023-11-10T09:03:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/oci/legacy.go	37.7%	38.7%	1.0

tekton-robot · 2023-11-21T09:06:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/oci/legacy.go	37.7%	41.3%	3.6

Previously while providing repo url value for storage oci repository, chains controller was giving an error as `a digest must contain exactly one '@' separator (e.g. registry/repository@digest)` because, it was not able to add digest Hence this patch fixes it, by formatting the value provided by the user and thus storing the attestations/signatures in the provided location Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>

tekton-robot · 2023-11-22T01:56:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/oci/legacy.go	37.7%	40.0%	2.3

lcarva

/lgtm

tekton-robot · 2023-11-22T14:33:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lcarva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot requested review from chitrangpatel and lcarva October 27, 2023 17:03

tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 27, 2023

lcarva reviewed Oct 27, 2023

View reviewed changes

Comment thread pkg/chains/storage/oci/legacy.go Outdated

lcarva reviewed Oct 27, 2023

View reviewed changes

Comment thread pkg/chains/storage/oci/legacy.go Outdated

lcarva reviewed Oct 27, 2023

View reviewed changes

PuneetPunamiya force-pushed the fix-storage-oci-repo branch from 86aacdc to 7066899 Compare November 9, 2023 15:16

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2023

PuneetPunamiya force-pushed the fix-storage-oci-repo branch from 7066899 to 3524079 Compare November 9, 2023 15:31

lcarva reviewed Nov 9, 2023

View reviewed changes

Comment thread pkg/chains/storage/oci/legacy.go Outdated

PuneetPunamiya force-pushed the fix-storage-oci-repo branch from 3524079 to 06e45a4 Compare November 10, 2023 06:57

PuneetPunamiya force-pushed the fix-storage-oci-repo branch from 06e45a4 to 31d6332 Compare November 10, 2023 08:52

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2023

PuneetPunamiya force-pushed the fix-storage-oci-repo branch from 31d6332 to 1c754db Compare November 10, 2023 08:54

lcarva suggested changes Nov 20, 2023

View reviewed changes

PuneetPunamiya force-pushed the fix-storage-oci-repo branch from 1c754db to 566e789 Compare November 21, 2023 09:00

PuneetPunamiya commented Nov 21, 2023

View reviewed changes

Comment thread pkg/chains/storage/oci/legacy.go Outdated

lcarva reviewed Nov 21, 2023

View reviewed changes

Comment thread pkg/chains/storage/oci/legacy.go Outdated

PuneetPunamiya force-pushed the fix-storage-oci-repo branch from 566e789 to 998ce1e Compare November 22, 2023 01:50

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2023

lcarva approved these changes Nov 22, 2023

View reviewed changes

tekton-robot assigned lcarva Nov 22, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023

tekton-robot merged commit dd3620e into tektoncd:main Nov 22, 2023

lcarva mentioned this pull request Dec 1, 2023

Adds initial Attestor implementation. #998

Closed

6 tasks

Conversation

PuneetPunamiya commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Oct 27, 2023

Uh oh!

Uh oh!

Uh oh!

lcarva left a comment

Choose a reason for hiding this comment

Uh oh!

PuneetPunamiya commented Nov 2, 2023

Uh oh!

tekton-robot commented Nov 9, 2023

Uh oh!

PuneetPunamiya commented Nov 9, 2023

Uh oh!

tekton-robot commented Nov 9, 2023

Uh oh!

Uh oh!

tekton-robot commented Nov 10, 2023

Uh oh!

tekton-robot commented Nov 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Nov 21, 2023

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Nov 22, 2023

Uh oh!

lcarva left a comment

Choose a reason for hiding this comment

Uh oh!

tekton-robot commented Nov 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PuneetPunamiya commented Oct 27, 2023 •

edited

Loading