Add temporal schedule list-matching-times command …#1047
Open
NasitSony wants to merge 3 commits into
Open
Conversation
…tScheduleMatchingTimes RPC in the CLI. Allows users to preview when a schedule will fire within a given time range without executing workflows. Closes temporalio#1030
|
|
Contributor
|
@NasitSony thank you for your contribution! Could to add a functional test for this command? 1 with the human readable output and 1 with json? Also, there's a new PR template, could you follow it? |
Author
|
@chaptersix Thanks for the feedback! I'll add the functional tests and update to the new PR template. |
Author
|
@chaptersix Added functional tests for text and JSON output, and fixed JSON output to use PrintStructured for proper array format. Also updated the PR description to follow the new template. Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the ListScheduleMatchingTimes RPC in the CLI.
Allows users to preview when a schedule will fire within
a given time range without executing workflows.
What was changed
Added
temporal schedule list-matching-timescommand implementing theListScheduleMatchingTimesRPC. Added functional tests for both text and JSON output. Fixed JSON output to usePrintStructuredfor proper array format.Why?
The Temporal CLI was missing a command for the
ListScheduleMatchingTimesRPC. Users can now preview when a schedule would fire within a given time range without executing workflows.Checklist