Fix task-queue config set help: use real fairness weight flag names#1056
Merged
Conversation
The help text for 'temporal task-queue config set' referenced --fairness-key-weight-set, --fairness-key-weight-unset, and --fairness-key-weight-unset-all - none of which exist. The real flags, defined a few lines below in the same YAML, are --fairness-key-weight (with key=default to unset a single key) and --fairness-key-weight-clear-all. Updated the example block and the unset instructions in the description to match the actual flag names, and regenerated commands.gen.go.
|
|
chaptersix
approved these changes
May 29, 2026
This was referenced May 29, 2026
fix: use allow instead of ignore for dependency-type in dependabot config
chaptersix/temporal-cli#10
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
temporal task-queue config sethelp text referenced three flags that don't exist:--fairness-key-weight-set <key>=<weight>--fairness-key-weight-unset <key>--fairness-key-weight-unset-allThe real flags, defined a few lines below in the same YAML block, are:
--fairness-key-weight <key>=<weight>(with<key>=defaultto unset a single key)--fairness-key-weight-clear-allThis PR updates the example block and the unset instructions in
commands.yamlto match, and regeneratescommands.gen.go. Verified locally withgo run ./cmd/temporal task-queue config set --help.This bug also surfaces in the auto-generated docs site at docs/cli/task-queue.mdx, which a customer hit in this Slack thread. The docs PR over in
temporalio/documentation#4625works around it by referencing the real flag names directly.