Skip to content

fix(types): allow all elements#500

Closed
nickserv wants to merge 2 commits into
mainfrom
allow-all-elements
Closed

fix(types): allow all elements#500
nickserv wants to merge 2 commits into
mainfrom
allow-all-elements

Conversation

@nickserv

@nickserv nickserv commented Nov 20, 2020

Copy link
Copy Markdown
Member

Port of testing-library/react-testing-library#833

Checklist:

  • Documentation
  • Tests
  • Typings
  • Ready to be merged

@kentcdodds kentcdodds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentcdodds

Copy link
Copy Markdown
Member

Not sure what's up with ci

@codecov

codecov Bot commented Nov 21, 2020

Copy link
Copy Markdown

Codecov Report

Merging #500 (b7307e4) into master (f7620ab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #500   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          615       615           
  Branches       200       200           
=========================================
  Hits           615       615           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7620ab...b7307e4. Read the comment docs.

@nickserv

Copy link
Copy Markdown
Member Author

I fixed the build, but let's still wait to merge, I want to check something

@nickserv nickserv marked this pull request as draft November 21, 2020 02:17
@ph-fritsche

Copy link
Copy Markdown
Member

I'll close this for now as it is outdated. If you like to tackle this again please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants