Skip to content

Fix typos#417

Closed
szepeviktor wants to merge 1 commit into
thecodingmachine:masterfrom
szepeviktor:typos
Closed

Fix typos#417
szepeviktor wants to merge 1 commit into
thecodingmachine:masterfrom
szepeviktor:typos

Conversation

@szepeviktor

@szepeviktor szepeviktor commented Apr 9, 2023

Copy link
Copy Markdown
Contributor

Using https://github.com/crate-ci/typos
Something like #416 on a bigger scale.

This is all I can offer. Please make changes yourself.
If you wish I could revert generated/* files so you can work easier.

@szepeviktor

szepeviktor commented Apr 9, 2023

Copy link
Copy Markdown
Contributor Author

💡 There is a new file called rnp.php
https://www.php.net/manual/en/book.rnp.php 👀

@staabm

staabm commented Nov 28, 2024

Copy link
Copy Markdown
Collaborator

hey.

I am one of the new maintainers which recently got invited to revive this repo.

Thanks for the time you invested in this PR.
In the meantime we merged other PRs which results in conflicts here.

Feel free to contribute a similar PR in the future, after we worked thru the merge queue and got a PHP 8.1+ release out the door

thanks again

@staabm staabm closed this Nov 28, 2024
@szepeviktor

Copy link
Copy Markdown
Contributor Author

@staabm Would you welcome a PR fixing misspellings?

@szepeviktor szepeviktor deleted the typos branch November 28, 2024 10:56
@staabm

staabm commented Nov 28, 2024

Copy link
Copy Markdown
Collaborator

Would you welcome a PR fixing misspellings?

yes, but not now. please wait until we worked out a PHP 8.1 compatible release

@szepeviktor

Copy link
Copy Markdown
Contributor Author

Is it time to reopen this PR?

@shish

shish commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

I'd be happy for a PR with typo-fixing, though so much has changed that it might be worth starting from scratch rather than trying to rebase and deal with merge conflicts 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants