Skip to content

Use less-old phpstan#462

Merged
staabm merged 1 commit into
thecodingmachine:masterfrom
shish:pr462
Nov 28, 2024
Merged

Use less-old phpstan#462
staabm merged 1 commit into
thecodingmachine:masterfrom
shish:pr462

Conversation

@shish

@shish shish commented Nov 28, 2024

Copy link
Copy Markdown
Collaborator

phpstan 1.5 is very out of date and the API for defining rules is incompatible with the current API.

tests are currently failing, but they're failing upstream and they should pass once all the other PRs are merged

PHPStan 2.0 was released a few days ago, but other parts of our dependency tree are locked to "1.X", so for now I'm just updating to "most recent 1.X" and we can look at 2.0 after the rest is stable.

phpstan 1.5 is very out of date and the API for defining rules is incompatible with the current API.

tests are currently failing, but they're failing upstream and they should pass once all the other PRs are merged

PHPStan 2.0 was released a few days ago, but other parts of our dependency tree are locked to "1.X", so for now I'm just updating to "most recent 1.X" and we can look at 2.0 after the rest is stable.
@staabm staabm merged commit 4b73aa4 into thecodingmachine:master Nov 28, 2024
@staabm

staabm commented Nov 28, 2024

Copy link
Copy Markdown
Collaborator

thanks

@shish shish deleted the pr462 branch December 2, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants