Skip to content

TUF website Docsy themed version - #68

Merged
chalin merged 13 commits into
theupdateframework:docsyfrom
Dindihub:docsy-tufio
Sep 4, 2024
Merged

TUF website Docsy themed version#68
chalin merged 13 commits into
theupdateframework:docsyfrom
Dindihub:docsy-tufio

Conversation

@Dindihub

@Dindihub Dindihub commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

This is the Docsy theme version of the TUF website.

Please review @chalin @lukpueh

@chalin chalin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.
Also, I'm not seeing any content for content/en/resources

Comment thread yarn.lock Outdated
Comment thread static/papers/attacks-on-package-managers-ccs2008.pdf
Comment thread package-lock.json Outdated
Signed-off-by: sandra <sadindi03@gmail.com>
@chalin

chalin commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

@Dindihub - FYI, I'm working with @nate-double-u to try to get deploy previews enabled for the docsy branch and this PR.

Signed-off-by: sandra <sadindi03@gmail.com>
Comment thread content/en/resources/publications.md Outdated
Signed-off-by: sandra <sadindi03@gmail.com>
@Dindihub

Copy link
Copy Markdown
Contributor Author

See inline comments. Also, I'm not seeing any content for content/en/resources

It was in the .gitignore file as resources/. It's now visible

Dindihub and others added 4 commits August 30, 2024 18:33
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Signed-off-by: sandra <sadindi03@gmail.com>

@chalin chalin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dindihub - take a look at https://deploy-preview-68--theupdateframework.netlify.app and you'll see that it is different from your repo's rendition. I'll fix that; it seems to be because the version of Hugo being used, isn't correct due to the wrong build commands being used.

Note that you'll need to copy over and include the following in this PR

  • All of the dot files and folders such as .github, .cspell.yml, etc.
  • The LICENSE files
  • The updated Makefile
  • The updated README.md (keep the current badge)

Edit: track required additions via:

@chalin

chalin commented Sep 4, 2024

Copy link
Copy Markdown
Collaborator

Hmm, the version of docsy included currently in this PR is old; in particular, it doesn't match the version you're using over in https://github.com/Dindihub/docsy-tuf.io/tree/main/themes. Let me fix that to see if it helps make the hero image appear.

@chalin

chalin commented Sep 4, 2024

Copy link
Copy Markdown
Collaborator

Updating docsy doesn't seem to help. I'm not sure why the hero image isn't displaying. I'll investigate further tomorrow.

@chalin

chalin commented Sep 4, 2024

Copy link
Copy Markdown
Collaborator

Ah, it's because of the Content-Security-Policy. I'll need to think about this more carefully and post here once I have an idea.

@JustinCappos et al. - would you be ok with the addition of style-src 'self' 'unsafe-inline' to the CSP here:

Content-Security-Policy = "default-src 'self' code.jquery.com fonts.googleapis.com fonts.gstatic.com use.fontawesome.com app.netlify.com netlify-cdp-loader.netlify.app youtube.com; frame-src youtube.com www.youtube.com"

@JustinCappos

Copy link
Copy Markdown
Member

Ah, it's because of the Content-Security-Policy. I'll need to think about this more carefully and post here once I have an idea.

@JustinCappos et al. - would you be ok with the addition of style-src 'self' 'unsafe-inline' to the CSP here:

Content-Security-Policy = "default-src 'self' code.jquery.com fonts.googleapis.com fonts.gstatic.com use.fontawesome.com app.netlify.com netlify-cdp-loader.netlify.app youtube.com; frame-src youtube.com www.youtube.com"

Is there a reasonable workaround? Why do we need this? It's a bad look for a security project to disable security controls, even if they don't matter in this case.

@chalin

chalin commented Sep 4, 2024

Copy link
Copy Markdown
Collaborator

Is there a reasonable workaround? Why do we need this? It's a bad look for a security project to disable security controls, even if they don't matter in this case.

Ok, I'll propose a workaround in a followup PR. Thanks for the feedback @JustinCappos.

Edit: track workaround via:

@chalin chalin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough as a first PR over the docsy branch. I'll follow up with the issues mentioned here but not yet addressed.

@chalin
chalin merged commit 8b69df3 into theupdateframework:docsy Sep 4, 2024
Dindihub added a commit to Dindihub/theupdateframework.io-DocsyTheme that referenced this pull request Sep 5, 2024
Signed-off-by: sandra <sadindi03@gmail.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants