Skip to content

Update esprima to version 3.1.3 - #22

Open
alicoding wants to merge 1 commit into
thlorenz:masterfrom
alicoding:updateEsprima
Open

alicoding wants to merge 1 commit into
thlorenz:masterfrom
alicoding:updateEsprima

Conversation

@alicoding

@alicoding alicoding commented Jun 4, 2017 •

Copy link
Copy Markdown
Collaborator

I have to fix this broken test test/fixtures/use-strict-without-semicolon.js
Since using use strict it was throwing an error when parsing the code about
missing semicolon here

closes #21

@alicoding

Copy link
Copy Markdown
Collaborator Author

I also added package-lock.json which is part of npm@5

@alicoding

Copy link
Copy Markdown
Collaborator Author

I also added a test here :)

@thlorenz

thlorenz commented Jun 5, 2017 •

Copy link
Copy Markdown
Owner

Hi, thanks for the work I will review when I get a chance. In the meantime please remove all unrelated changes:

  • lots of whitespace changes (please undo)
  • package-lock.json is not necessary for this change, please remove

Also please stick to the range scheme I'm using for dependencies in the package.json, i.e. don't use ^, but ~ instead.

Thanks

I have to fix this broken test `test/fixtures/use-strict-without-semicolon.js`
Since using `use strict` it was throwing an error when parsing the code about
missing semicolon here
@alicoding

Copy link
Copy Markdown
Collaborator Author

Done :)

@thlorenz

thlorenz commented Jun 5, 2017

Copy link
Copy Markdown
Owner

Many thanks :)

I merged and published as 1.0. I'd love to see some docs regarding the moveStrictWanted feature you added.
Please when you have some time add that.

I also made you collaborator.

So in the future you can merge changes to master after we agree on a PR, following this guide.
I will then version and publish to npm.

Thanks.

@alicoding

alicoding commented Jun 5, 2017 •

Copy link
Copy Markdown
Collaborator Author

Actually, I did not add that feature, but I don't mind adding documentation for that :) and thanks!

@thlorenz

thlorenz commented Jun 5, 2017

Copy link
Copy Markdown
Owner

Ah ok, got confused since there were some changes around there ...
But yeah any help here would be greatly appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ES6 parsing error

2 participants