Skip to content

chore(deps): update dependency imposter to 0.2.17 - #7031

Merged
thomhurst merged 1 commit into
mainfrom
renovate/imposter-0.x
Oct 11, 2026
Merged

thomhurst merged 1 commit into
mainfrom
renovate/imposter-0.x

Conversation

@thomhurst

@thomhurst thomhurst commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

This PR contains the following updates:

Package Type Update Change
Imposter nuget patch 0.2.14 → 0.2.17

Release Notes

themidnightgospel/Imposter (Imposter)

v0.2.17: Closed generic registrations, type parameter name clashes

Compare Source

Fixes

  • Closed generic registrations (#​336, closes #​318 and #​329). A closed registration such as typeof(IRepository<int>) now generates the open type's imposter, IRepositoryImposter<T>, as IMP006 and the docs already said:
    • Under C# 14 it failed to compile (CS9295), because its Imposter() extension was declared for IRepository<int>.
    • Registering one generic type more than once, closed and closed or closed and open, reported IMP007 and generated nothing. The registrations now share the one imposter, and each closed one still reports IMP006.
    • Change: with putInTheSameNamespace: false, a closed registration's imposter now goes into the open type's namespace, such as Imposters.Sample.IRepository_T_ instead of Imposters.Sample.IRepository_int_.
    • A type nested in a generic class keeps the containing type's type arguments: typeof(Outer<int>.Inner) generates as before and no longer reports IMP006.
  • Type parameters named like the imposter's own types (#​338, closes #​330). A target such as IRepo<GetDelegate>, whose type parameter has the name of a type the imposter generates, failed to compile. Those types are now renamed, as they already were for a member of that name.

v0.2.16: Case-only target names, fewer allocations per call

Compare Source

Fixes

  • Targets whose names differ only in letter case (#​334, closes #​316). Registering two targets such as IFoo and Ifoo made the generator fail with CS8785, and no imposter of the project was generated. Roslyn compares generated file names ignoring case, so the two files clashed. Such targets' files now get a hash of the target's name in their file name, as generic targets' files already do. Every other file keeps its name.

Performance

  • Calls allocate less (#​321, closes #​315). Every call to an impersonated method, property or indexer used to allocate an enumerator to look for callbacks, even when none were registered. It now skips the lookup when there are none:
    • a property getter call no longer allocates;
    • a method call allocates 144 bytes instead of 216;
    • a property setter call 32 instead of 104;
    • an indexer getter call 104 instead of 176;
    • an indexer setter call 64 instead of 144.

v0.2.15: Less memory per generation

Compare Source

Performance

  • Less memory per generation (#​314, closes #​313). The generator worked out every method's setup signature for every target, to keep numbered setups such as Get_1() clear of other setup names. Most targets have no numbered setup, so it now does that only when one needs it. Generating 400 methods allocates 1.3% less (2.78 MB); the generated code is unchanged.

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@thomhurst thomhurst added dependencies Pull requests that update a dependency file PATCH renovate-bot labels Oct 11, 2026
@thomhurst
thomhurst enabled auto-merge (squash) October 11, 2026 20:41
@thomhurst
thomhurst deployed to Pull Requests October 11, 2026 20:41 — with GitHub Actions Active
@thomhurst
thomhurst deployed to Pull Requests October 11, 2026 20:41 — with GitHub Actions Active
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T22:15:09.562313Z 5b155fc New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 689b22c7-8351-4d39-8ea3-bc7b4db11f8a



📥 Commits

Reviewing files that changed from the base of the PR and between c8609b8 and 5b155fc.




📒 Files selected for processing (1)
  • Directory.Packages.props



🚧 Files skipped from review as they are similar to previous changes (1)
  • Directory.Packages.props



Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.





📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The centrally managed Imposter package version changed from 0.2.14 to 0.2.17.

Changes

Imposter package update

Layer / File(s) Summary
Update package version
Directory.Packages.props
The centrally managed Imposter package version changed from 0.2.14 to 0.2.17.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other





Merge Risk: ⚪ Minimal · up to 5b155

This is a small dependency version bump, and the release notes describe fixes and allocation improvements. No actionable merge-blocking risk was identified.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating the Imposter dependency from the existing version to 0.2.17.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR





  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version line,
From fourteen hops to seventeen.
One package number now has changed,
The rest of the props stay as arranged.
The rabbit bounds away, serene.

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High impact] The dependency update appears safe to merge.

Summary

Updates Imposter from 0.2.14 to 0.2.17 in Directory.Packages.props.

  • Projects using Imposter now resolve version 0.2.17.

Reviews (3) · Last reviewed commit: "chore(deps): update dependency imposter ..." · Reviewed by Greptile

@thomhurst
thomhurst force-pushed the renovate/imposter-0.x branch from 18d732f to c8609b8 Compare October 11, 2026 21:12
@thomhurst thomhurst changed the title chore(deps): update dependency imposter to 0.2.15 chore(deps): update dependency imposter to 0.2.16 Oct 11, 2026
@thomhurst
thomhurst deployed to Pull Requests October 11, 2026 21:13 — with GitHub Actions Active
@thomhurst
thomhurst deployed to Pull Requests October 11, 2026 21:13 — with GitHub Actions Active
@thomhurst
thomhurst deployed to Pull Requests October 11, 2026 21:13 — with GitHub Actions Active

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8609b831e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Directory.Packages.props Outdated
<PackageVersion Include="Microsoft.Testing.Platform" Version="2.5.1" />
<PackageVersion Include="Microsoft.Testing.Platform.MSBuild" Version="2.5.1" />
<PackageVersion Include="Imposter" Version="0.2.14"/>
<PackageVersion Include="Imposter" Version="0.2.16"/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align the package pin with the reviewed update

The commit title, dependency table, comparison link, and release notes all describe an upgrade to Imposter 0.2.15, but this line actually selects 0.2.16. As a result, reviewers and release tooling are approving a different dependency artifact than the one documented; either pin 0.2.15 or regenerate the change metadata and release notes for 0.2.16.

Useful? React with 👍 / 👎.

@thomhurst
thomhurst force-pushed the renovate/imposter-0.x branch from c8609b8 to 5b155fc Compare October 11, 2026 22:13
@thomhurst thomhurst changed the title chore(deps): update dependency imposter to 0.2.16 chore(deps): update dependency imposter to 0.2.17 Oct 11, 2026
@thomhurst
thomhurst deployed to Pull Requests October 11, 2026 22:13 — with GitHub Actions Active
@thomhurst
thomhurst deployed to Pull Requests October 11, 2026 22:13 — with GitHub Actions Active
@thomhurst
thomhurst deployed to Pull Requests October 11, 2026 22:13 — with GitHub Actions Active

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b155fcbf3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Directory.Packages.props
<PackageVersion Include="Microsoft.Testing.Platform" Version="2.5.1" />
<PackageVersion Include="Microsoft.Testing.Platform.MSBuild" Version="2.5.1" />
<PackageVersion Include="Imposter" Version="0.2.14"/>
<PackageVersion Include="Imposter" Version="0.2.17"/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align the pin with the documented 0.2.16 update

Fresh evidence since the existing review comment is that the pin has advanced again, now to 0.2.17, while the commit title, dependency table, comparison links, and release notes all stop at 0.2.16. Reviewers are therefore evaluating different dependency changes from the artifact that will be restored; either pin 0.2.16 or regenerate the update metadata and release notes for 0.2.17.

Useful? React with 👍 / 👎.

This was referenced Oct 14, 2026

This branch was successfully deployed

1 active deployment
Pull Requests — 5b155fcb Deployed Oct 11, 2026 by thomhurst via modularpipeline (windows-latest) #19850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file PATCH renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants