Repository navigation
chore(deps): update dependency imposter to 0.2.17 - #7031
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This is a small dependency version bump, and the release notes describe fixes and allocation improvements. No actionable merge-blocking risk was identified. Pre-merge checks |
|
|
18d732f to
c8609b8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8609b831e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <PackageVersion Include="Microsoft.Testing.Platform" Version="2.5.1" /> | ||
| <PackageVersion Include="Microsoft.Testing.Platform.MSBuild" Version="2.5.1" /> | ||
| <PackageVersion Include="Imposter" Version="0.2.14"/> | ||
| <PackageVersion Include="Imposter" Version="0.2.16"/> |
There was a problem hiding this comment.
Align the package pin with the reviewed update
The commit title, dependency table, comparison link, and release notes all describe an upgrade to Imposter 0.2.15, but this line actually selects 0.2.16. As a result, reviewers and release tooling are approving a different dependency artifact than the one documented; either pin 0.2.15 or regenerate the change metadata and release notes for 0.2.16.
Useful? React with 👍 / 👎.
c8609b8 to
5b155fc
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b155fcbf3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <PackageVersion Include="Microsoft.Testing.Platform" Version="2.5.1" /> | ||
| <PackageVersion Include="Microsoft.Testing.Platform.MSBuild" Version="2.5.1" /> | ||
| <PackageVersion Include="Imposter" Version="0.2.14"/> | ||
| <PackageVersion Include="Imposter" Version="0.2.17"/> |
There was a problem hiding this comment.
Align the pin with the documented 0.2.16 update
Fresh evidence since the existing review comment is that the pin has advanced again, now to 0.2.17, while the commit title, dependency table, comparison links, and release notes all stop at 0.2.16. Reviewers are therefore evaluating different dependency changes from the artifact that will be restored; either pin 0.2.16 or regenerate the update metadata and release notes for 0.2.17.
Useful? React with 👍 / 👎.
This PR contains the following updates:
0.2.14→0.2.17Release Notes
themidnightgospel/Imposter (Imposter)
v0.2.17: Closed generic registrations, type parameter name clashesCompare Source
Fixes
typeof(IRepository<int>)now generates the open type's imposter,IRepositoryImposter<T>, as IMP006 and the docs already said:Imposter()extension was declared forIRepository<int>.putInTheSameNamespace: false, a closed registration's imposter now goes into the open type's namespace, such asImposters.Sample.IRepository_T_instead ofImposters.Sample.IRepository_int_.typeof(Outer<int>.Inner)generates as before and no longer reports IMP006.IRepo<GetDelegate>, whose type parameter has the name of a type the imposter generates, failed to compile. Those types are now renamed, as they already were for a member of that name.v0.2.16: Case-only target names, fewer allocations per callCompare Source
Fixes
IFooandIfoomade the generator fail with CS8785, and no imposter of the project was generated. Roslyn compares generated file names ignoring case, so the two files clashed. Such targets' files now get a hash of the target's name in their file name, as generic targets' files already do. Every other file keeps its name.Performance
v0.2.15: Less memory per generationCompare Source
Performance
Get_1()clear of other setup names. Most targets have no numbered setup, so it now does that only when one needs it. Generating 400 methods allocates 1.3% less (2.78 MB); the generated code is unchanged.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.