Repository navigation
Merge the analyzer release tables under one New Rules section (RS2007) - #7174
Conversation
AnalyzerReleases.Shipped.md grouped its rules under '####' category headings. The release-tracking parser only accepts '## Release X' and '### New Rules' / '### Removed Rules' / '### Changed Rules' before a rule table, so it rejected the first category heading: both analyzer projects emitted RS2007 on every build and release tracking stopped there. Remove the category headings and the repeated table headers, keeping the rows in their existing category order. Both files now parse and the builds are free of RS2007. Fixes thomhurst#7171
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
[Low impact] The PR appears safe to merge. SummaryBoth analyzer projects now keep their shipped rules in one table under
No actionable issues found. Builds were not run during this review. Reviews (1) · Last reviewed commit: "fix(analyzers): merge the category table..." · Reviewed by Greptile |
|
Review: LGTM. The change is metadata-only. Merging each file's category tables into the single The PR description notes pre-existing RS2000 ( I could not run the build here. The review rests on reading the diff and on the red/green evidence in the description. |
|
Thanks @bfs2021 ! |
Description
AnalyzerReleases.Shipped.mdin both analyzer projects groups its rules under####category headings. The release-tracking format only accepts## Release Xand### New Rules/### Removed Rules/### Changed Rulesbefore a rule table, so the parser rejects the first category heading: every build ofsrc/TUnit.Analyzers/TUnit.Analyzers.csprojandsrc/TUnit.Assertions.Analyzers/TUnit.Assertions.Analyzers.csprojemits RS2007, and release tracking stops there.This merges each file's tables into the single
### New Rulestable, keeping the rows in their existing category order.Related Issue
Fixes #7171
Type of Change
Checklist
Required
TUnit-Specific Requirements
Testing
dotnet build src/TUnit.Analyzers/TUnit.Analyzers.csproj -c Release: 0 errors, no RS2007.dotnet build src/TUnit.Assertions.Analyzers/TUnit.Assertions.Analyzers.csproj -c Release: 0 errors, no RS2007.RS2007 ... AnalyzerReleases.Shipped.md(5,1)again; the patched files remove it.global.jsonpin at that version and reverted it afterwards; no SDK change is committed.Once the files parse, the builds also report RS2000 for
TUNIT_LANG_001(reported byLanguageVersionAnalyzer, absent from both release files) and RS2002 for the rules listed inAnalyzerReleases.Unshipped.mdthat no analyzer supports. Those are pre-existing tracking gaps rather than a consequence of the headings, so I left them out of this change.Summary by CodeRabbit