Add missing gen directories to the Dockerfile - #3233
Merged
Conversation
The docker build was failing locally with errors: ``` (...) => ERROR [gobuild 24/24] RUN GOOS=linux go build -ldflags "-X main.version=$VERSION -X main.revision=$REVISION" -a -o keep-clie 1.1s ------ > [gobuild 24/24] RUN GOOS=linux go build -ldflags "-X main.version=$VERSION -X main.revision=$REVISION" -a -o keep-client ./ && mv keep-client /usr/local/bin: \#32 1.096 pkg/tbtc/marshaling.go:9:2: no required module provides package github.com/keep-network/keep-core/pkg/tbtc/gen/pb; to add it: \#32 1.096 go get github.com/keep-network/keep-core/pkg/tbtc/gen/pb \#32 1.096 pkg/tecdsa/dkg/marshaling.go:10:2: no required module provides package github.com/keep-network/keep-core/pkg/tecdsa/dkg/gen/pb; to add it: \#32 1.096 go get github.com/keep-network/keep-core/pkg/tecdsa/dkg/gen/pb '#32 1.096 pkg/tecdsa/marshaling.go:10:2: no required module provides package github.com/keep-network/keep-core/pkg/tecdsa/gen/pb; to add it: '#32 1.096 go get github.com/keep-network/keep-core/pkg/tecdsa/gen/pb (...) ``` It turned out that we don't copy following directories for generation: ``` COPY ./pkg/tbtc/gen $APP_DIR/pkg/tbtc/gen COPY ./pkg/tecdsa/dkg/gen $APP_DIR/pkg/tecdsa/dkg/gen COPY ./pkg/tecdsa/gen $APP_DIR/pkg/tecdsa/gen ``` We add them here. Also we took and opportunity to sort the directories alphabeticaly.
pdyraga
approved these changes
Sep 1, 2022
nkuba
added a commit
that referenced
this pull request
Sep 8, 2022
The docker build was failing locally because of the missing dependency. This is something that we already been fixing in #3233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docker build was failing locally with errors:
It turned out that we don't copy the following directories for a generation:
We add them here.
Also, we took an opportunity to sort the directories alphabetically.