[WIP] Longshoreman: Better docker caching, keep-network pinned dependencies - #34
Merged
Conversation
We were copying the whole source directory into the image and then dep ensure-ing, but this means we'll run dep ensure every build. We now copy the Gopkg files in first, such that if they are unchanged we can skip the dep ensure step.
Member
|
Great start |
We mention both docker (easy) and how to build natively (slightly harder).
Contributor
Author
|
This is ready for final review/approval. |
mhluongo
approved these changes
Feb 12, 2018
| RUN apt-get install -y llvm g++ libgmp-dev libssl-dev git-core build-essential | ||
| ENV BN_VERSION=d1a44d2f242692601b3e150b59044ab82f265b65 | ||
| RUN git clone https://github.com/dfinity/bn | ||
| RUN git clone https://github.com/keep-network/bn |
lionakhnazarov
pushed a commit
to lionakhnazarov/keep-core
that referenced
this pull request
Jul 12, 2026
lionakhnazarov
pushed a commit
to lionakhnazarov/keep-core
that referenced
this pull request
Jul 12, 2026
…in epic Combine the per-PR Keep a Changelog entries (threshold-network#36, threshold-network#37, threshold-network#34, threshold-network#38, threshold-network#39, threshold-network#40, #8, #2, #14) into shared Added/Changed/Fixed/Security sections under [Unreleased].
lionakhnazarov
pushed a commit
to lionakhnazarov/keep-core
that referenced
this pull request
Aug 10, 2026
lionakhnazarov
pushed a commit
to lionakhnazarov/keep-core
that referenced
this pull request
Aug 10, 2026
…in epic Combine the per-PR Keep a Changelog entries (threshold-network#36, threshold-network#37, threshold-network#34, threshold-network#38, threshold-network#39, threshold-network#40, #8, #2, #14) into shared Added/Changed/Fixed/Security sections under [Unreleased].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things here:
Gopkg.lock.In #33, we decided to go with this approach using
dep. #30 is still open, but I think these changes will be relevant no matter what our conclusion there.