refactor(perf-trace): embed devtools frontend from appspot#278
Merged
Conversation
erickzhao
changed the title
samuelmaddock
approved these changes
Nov 4, 2025
Contributor
samuelmaddock
left a comment
samuelmaddock
left a comment
There was a problem hiding this comment.
lgtm! I think this is the last use of oop: if we wanted to clean that up too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to some great upstream work from @samuelmaddock, we can now load performance traces to an instance of Chrome DevTools via the
window.postMessageAPI.See Sam's Chromium CLs:
This PR refactors the
<DevtoolsView/>component to load traces from https://chrome-devtools-frontend.appspot.com/, and drops thedevtools-frontend-prebuiltnpm dependency (this should have the effect of dropping 20MB from our final bundle size).