Skip to content
This repository was archived by the owner on Jun 2, 2024. It is now read-only.

Only unlink existing files#31

Merged
timothymarois merged 1 commit into
tmarois:1.0from
OFFLINE-GmbH:1.0
Sep 29, 2018
Merged

Only unlink existing files#31
timothymarois merged 1 commit into
tmarois:1.0from
OFFLINE-GmbH:1.0

Conversation

@tobias-kuendig

Copy link
Copy Markdown
Contributor

If for any reason the index file does not exist the delete action should be considered successful.

Whithout this check the deletion of non-existent DB entries fails with an ErrorException.

@coveralls

coveralls commented Sep 29, 2018

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 120

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 92.788%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Filesystem.php 1 2 50.0%
Totals Coverage Status
Change from base Build 118: -0.2%
Covered Lines: 476
Relevant Lines: 513

💛 - Coveralls

@timothymarois

Copy link
Copy Markdown
Member

Perfect. I like it. I'll push this in the next release.

@timothymarois timothymarois merged commit 33c4afe into tmarois:1.0 Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants