ci: compute affected integration test dialects from the import graph - #8131
Merged
Conversation
georgesittas
commented
Aug 11, 2026
Collaborator
Author
There was a problem hiding this comment.
These removals were intentional: nobody did /integration-tests so we will now run exactly what's needed.
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing:
Overallmain: 182937 total, 160863 passed (pass rate: 87.9%) sqlglot:jo/precise_integration_test_runner: 182937 total, 160863 passed (pass rate: 87.9%) Transitions: ✅ All tests passed |
fivetran-kwoodbeck
approved these changes
Aug 12, 2026
georgesittas
force-pushed
the
jo/precise_integration_test_runner
branch
from
August 12, 2026 16:37
3ea507e to
3f202a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hardcoded path lists in
get_integration_test_params.pywith a static AST scan ofsqlglot's imports: a changed module triggers a dialect iff the dialect's module (or a module the
test harness imports) transitively imports it, including lazy function-level imports and excluding
TYPE_CHECKING-only ones. Also points the harness atqualify_columnsforquote_identifierssooptimizer.py's rule imports don't drag every optimizer rule into the closures.