Skip to content

fix(mysql): map %x and %r date format specifiers [CLAUDE] #8142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fivetran-kwoodbeck merged 3 commits into from
Aug 13, 2026
+26 −0
Merged

fix(mysql): map %x and %r date format specifiers [CLAUDE] #8142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d825d35
fix(mysql): map %v, %x and %r date format specifiers
codeAnqiang-ma Aug 12, 2026
361b6c5
fix(mysql): drop %v mapping to keep native %V intact on generation
codeAnqiang-ma Aug 13, 2026
2f46543
ajusted comments
fivetran-kwoodbeck Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sqlglot/dialects/mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,11 @@ class MySQL(Dialect):
"%u": "%W",
"%k": "%-H",
"%l": "%-I",
"%r": "%I:%M:%S %p",
"%T": "%H:%M:%S",
"%W": "%A",
"%x": "%G",
# %v (ISO week) is unmapped due to collision with %V (roundtrip issue)
}

VALID_INTERVAL_UNITS = {
Expand Down
23 changes: 23 additions & 0 deletions tests/dialects/test_mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,29 @@ def test_date_format(self):
"snowflake": "SELECT TO_CHAR(CAST('1900-10-04 22:23:00' AS TIMESTAMP), 'DD yy DY DD mm mon')",
},
)
self.validate_all(
"SELECT DATE_FORMAT('2021-01-01 22:23:00', '%x')",
write={
"mysql": "SELECT DATE_FORMAT('2021-01-01 22:23:00', '%x')",
"duckdb": "SELECT STRFTIME(CAST('2021-01-01 22:23:00' AS TIMESTAMP), '%G')",
},
)
self.validate_all(
"SELECT DATE_FORMAT(CAST('2021-01-01 22:23:00' AS DATETIME), '%x')",
read={
"duckdb": "SELECT STRFTIME(CAST('2021-01-01 22:23:00' AS TIMESTAMP), '%G')",
},
)
self.validate_all(
"SELECT DATE_FORMAT('2007-10-04 22:23:00', '%r')",
write={
"mysql": "SELECT DATE_FORMAT('2007-10-04 22:23:00', '%r')",
"duckdb": "SELECT STRFTIME(CAST('2007-10-04 22:23:00' AS TIMESTAMP), '%I:%M:%S %p')",
},
)
self.validate_identity("SELECT DATE_FORMAT(x, '%X-%V')")
self.validate_identity("SELECT DATE_FORMAT(x, '%x-%v')")
self.validate_identity("SELECT DATE_FORMAT(x, '%U')")

def test_mysql_time(self):
self.validate_identity("TIME_STR_TO_UNIX(x)", "UNIX_TIMESTAMP(x)")
Expand Down
Loading