Stack overflow when transacting :db.type/tupleAttrs with a :db.type/ref attr through :db.fn/call #483

Activity

1. seepel commented on Jan 23, 2025

   

   seepel

   on Jan 23, 2025

   Author

   More actions

   Here is all of that as one code block

   (def conn (d/create-conn {:provider/name {:db/unique :db.unique/identity}
                             :service/provider {:db/cardinality :db.cardinality/one
                                                :db/valueType :db.type/ref}
                             :service/name {:db/cardinality :db.cardinality/one}
                             :service/pk {:db/valueType :db.type/tuple
                                          :db/tupleAttrs [:service/provider :service/name]
                                          :db/unique :db.unique/identity}}))
   (def tx [{:provider/name "googleapis.com"}
            {:service/provider [:provider/name "googleapis.com"]
             :service/name "gmail/v1"}])
   (def tx-call [[:db.fn/call (fn [_db tx] tx) tx]])
   ;; Transacting the tx with the call with an empty db seems to go fine
   (clojure.pprint/pprint (:tx-data (d/transact! conn tx-call)))
   ; (out) [#datascript/Datom [1 :provider/name "googleapis.com" 536870913 true]
   ; (out)  #datascript/Datom [2 :service/provider 1 536870913 true]
   ; (out)  #datascript/Datom [2 :service/name "gmail/v1" 536870913 true]
   ; (out)  #datascript/Datom [2 :service/pk [1 "gmail/v1"] 536870913 true]]
                                                                                                    
   ;; Transacting against a non-empty db with duplicate data seems to go fine
   (clojure.pprint/pprint (:tx-data (d/transact! conn tx))) ;; tx-report
   ; (out) []
                                                                                                    
   ;; Transacting against a non-empty db with duplicate data overflows
   (clojure.pprint/pprint (:tx-data (d/transact! conn tx-call)))
   ; (err) Execution error (StackOverflowError) at datascript.db/is-attr? (db.cljc:1161).
   ; (err) null    
                                                                                                    
   ;; Transacting against a non-empty db with duplicate data overflows in random spots
   (clojure.pprint/pprint (:tx-data (d/transact! conn tx-call)))
   ; (err) Execution error (StackOverflowError) at datascript.db$reify__3146/compare (db.cljc:543).
   ; (err) null
   (clojure.pprint/pprint (:tx-data (d/transact! conn tx-call)))
   ; (err) Execution error (StackOverflowError) at datascript.db$reify__3146/compare (db.cljc:543).
   ; (err) null
   (clojure.pprint/pprint (:tx-data (d/transact! conn tx-call)))
   ; (err) Execution error (StackOverflowError) at datascript.db$reify__3158/compare (db.cljc:558).
   ; (err) null
   (clojure.pprint/pprint (:tx-data (d/transact! conn tx-call)))
   ; (err) Execution error (StackOverflowError) at datascript.db/is-attr? (db.cljc:1161).
   ; (err) null
   (clojure.pprint/pprint (:tx-data (d/transact! conn tx-call)))
   ; (err) Execution error (StackOverflowError) at datascript.db.DB/_search (db.cljc:671).
   ; (err) null
2. tonsky commented on Jan 30, 2025

   

   tonsky

   on Jan 30, 2025

   Owner

   More actions

   Oh wow. A lot of stuff come together for this to fail. There’s a loop in retry-with-tempids that happen when you do upserts. It normally works but here it fails because you call a function that generates new tempids and it can’t detect cycle because of that.