fix: enable Ctrl-C in local runs - #140
Merged
socksy merged 1 commit intoDec 12, 2025
Merged
Conversation
Contributor
|
This PR is targeting If this is a regular feature/fix PR, please change the base branch to Current base: |
bradhe
approved these changes
Dec 12, 2025
bradhe
left a comment
bradhe
left a comment
Contributor
There was a problem hiding this comment.
THANK YOU. This was really annoying me.
socksy
deleted the
feature/tow-1250-when-running-tower-run-local-on-notebooks-and-ctrl-c-the
branch
December 12, 2025 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the same pattern for checking if in MCP mode as we do for remote runs, but on thinking about it I am not 100% sure it's necessary to differentiate any more — I would investigate and change it for both though, here I'm just trying to get the same behaviour as with remote runs.
Used AI to help me research the rust thing of "how do I get access to the ability to cancel the app".
First rabbithole was cloning the application cancellation token, and debugging lifecycle stuff. However, I found it simpler to follow by wrapping the app in an Arc<Mutex<>>, and have both the stream process and the main control loop have references to the same app, and call
.terminate()on it directly.