Add some commonly-used environment variables to child app environments - #160
Merged
Merged
Conversation
socksy
approved these changes
Jan 14, 2026
socksy
left a comment
socksy
left a comment
Contributor
There was a problem hiding this comment.
I am pretty sure the $PATH one is gonna bite us in the arse soon but let's get this in to fix $HOME
Contributor
Author
|
I agree re: $PATH. We want a scrubbed/default version of $PATH but I couldn't really think of how to get it at the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users reported weird behavior when installing certain third-party libraries and using them with Tower. Turns out, they expected to have a
$HOMEenv var to save some downloaded content to. We jettisoned that env var while scrubbing the environment for other secrets that may be lurking.This PR adds it and a few other important UNIX-y ones back in to Unix environments.