Add full overview to catalogs show - #329
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
sammuti
approved these changes
Jul 23, 2026
bradhe
added a commit
that referenced
this pull request
Jul 27, 2026
Resolves the conflict in catalogs.rs, which was entirely in that one file. Two things had landed on develop since this branch was cut. #329 added the `--full` overview to `catalogs show`, which this branch also carries its own copy of, and #331 moved the DuckDB plumbing out into the tower-duckdb crate. The overlap on `--full` is what made the conflict large: the same feature existed on both sides. Resolved by taking develop's catalogs.rs and re-applying only what is unique to this branch, the `knowledge` command and its helpers, rather than hand-merging hunks of duplicated work. So the `--full` implementation is develop's, which is the version that was reviewed and merged and has since been through the tower-duckdb refactor; `run_duckdb_query` and `duckdb_value_to_json` are gone from this file because they now live in tower-duckdb, and their tests moved with them; and `knowledge` is unchanged from this branch, with all eleven of its tests restored. Verified: 112 tests pass (develop's 101 plus this branch's 11), `catalogs knowledge` and `catalogs query --max-rows` both work in the built binary, and catalogs.rs has no clippy warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--fullparameter totower catalogs showso that we can get columns, tables, schemas, and namespaces all in one go. Gives agents a full picture of what's in the catalog with one go at it.Example