Skip to content

Add full overview to catalogs show - #329

Merged
bradhe merged 2 commits into
developfrom
features/add-full-overview-to-catalogs-show
Jul 23, 2026
Merged

Add full overview to catalogs show#329
bradhe merged 2 commits into
developfrom
features/add-full-overview-to-catalogs-show

Conversation

@bradhe

@bradhe bradhe commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Adds a --full parameter to tower catalogs show so that we can get columns, tables, schemas, and namespaces all in one go. Gives agents a full picture of what's in the catalog with one go at it.

Example

$ cargo run -- catalogs show --full default                   
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.36s
     Running `target/debug/tower catalogs show --full default`
A newer version of tower is available: 0.3.69 (you have 0.3.70-rc.1)
To upgrade, run: pip install --upgrade tower
✔ Listing tables... Done!
Catalog: default
Type: tower-catalog
Environment: default

Properties
 Name              Runtime Var                                   Preview    
----------------------------------------------------------------------------
 uri               PYICEBERG_CATALOG__DEFAULT__URI               [REDACTED]  
 warehouse         PYICEBERG_CATALOG__DEFAULT__WAREHOUSE         [REDACTED]  
 storage_location  PYICEBERG_CATALOG__DEFAULT__STORAGE_LOCATION  [REDACTED]  
 ro_credential     PYICEBERG_CATALOG__DEFAULT__RO_CREDENTIAL     [REDACTED]  
 ro_scope          PYICEBERG_CATALOG__DEFAULT__RO_SCOPE          [REDACTED]  
 credential        PYICEBERG_CATALOG__DEFAULT__CREDENTIAL        [REDACTED]  
 scope             PYICEBERG_CATALOG__DEFAULT__SCOPE             [REDACTED]  

Tables
bronze.account_plans
 Column        Type                     
----------------------------------------
[REDACTED]           

bronze.accounts
 Column                  Type                     
--------------------------------------------------
[REDACTED]

# snip

bronze.users
 Column                               Type                     
---------------------------------------------------------------
[REDACTED]            

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f51b37a2-5d7a-49d6-a1fc-6b1b988e95ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch features/add-full-overview-to-catalogs-show

Comment @coderabbitai help to get the list of available commands.

@bradhe
bradhe merged commit ca498a2 into develop Jul 23, 2026
29 checks passed
@bradhe
bradhe deleted the features/add-full-overview-to-catalogs-show branch July 23, 2026 09:56
bradhe added a commit that referenced this pull request Jul 27, 2026
Resolves the conflict in catalogs.rs, which was entirely in that one file.

Two things had landed on develop since this branch was cut. #329 added the
`--full` overview to `catalogs show`, which this branch also carries its own copy
of, and #331 moved the DuckDB plumbing out into the tower-duckdb crate. The
overlap on `--full` is what made the conflict large: the same feature existed on
both sides.

Resolved by taking develop's catalogs.rs and re-applying only what is unique to
this branch, the `knowledge` command and its helpers, rather than hand-merging
hunks of duplicated work. So the `--full` implementation is develop's, which is
the version that was reviewed and merged and has since been through the
tower-duckdb refactor; `run_duckdb_query` and `duckdb_value_to_json` are gone
from this file because they now live in tower-duckdb, and their tests moved with
them; and `knowledge` is unchanged from this branch, with all eleven of its tests
restored.

Verified: 112 tests pass (develop's 101 plus this branch's 11), `catalogs
knowledge` and `catalogs query --max-rows` both work in the built binary, and
catalogs.rs has no clippy warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants