Skip to content

cargo fmt tower-cmd/ - #337

Open
socksy wants to merge 1 commit into
mainfrom
chore/cargo-fmt-tower-cmd
Open

cargo fmt tower-cmd/#337
socksy wants to merge 1 commit into
mainfrom
chore/cargo-fmt-tower-cmd

Conversation

@socksy

@socksy socksy commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

see title

Summary by CodeRabbit

  • Refactor
    • Improved code formatting and readability across catalog query execution, REST column handling, Iceberg type rendering, and knowledge command processing.
    • No user-facing behavior or command functionality changed.

@socksy
socksy requested review from konstantinoscs and sammuti July 30, 2026 15:40
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ WARNING: This PR targets main instead of develop

This PR is targeting main which will trigger a production deployment when merged.

If this is a regular feature/fix PR, please change the base branch to develop.
If this is intentional (e.g., hotfix), you can ignore this warning.

Current base: main
Recommended base: develop

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 39724e1a-ce7d-4e8b-a04d-03b07442824b

📥 Commits

Reviewing files that changed from the base of the PR and between 8d5ef43 and add931d.

📒 Files selected for processing (2)
  • crates/tower-cmd/src/catalogs.rs
  • crates/tower-cmd/src/lib.rs

📝 Walkthrough

Walkthrough

Reformats catalog query helpers, catalog rendering expressions, knowledge CLI handlers and tests, and catalogs knowledge dispatch without changing behavior or public APIs.

Changes

Catalog CLI refactor

Layer / File(s) Summary
Catalog query and rendering formatting
crates/tower-cmd/src/catalogs.rs
DuckDB closures and catalog rendering expressions are reformatted without changing execution or output behavior.
Knowledge handlers and tests
crates/tower-cmd/src/catalogs.rs
Knowledge handler lookups and parser tests use expanded multiline formatting with unchanged inputs and assertions.
Knowledge subcommand dispatch
crates/tower-cmd/src/lib.rs
The catalogs knowledge match arm is expanded into a multiline block while preserving handlers and fallback behavior.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: sammuti

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the formatting-only changes applied to tower-cmd/.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/cargo-fmt-tower-cmd

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ WARNING: This PR targets main instead of develop

This PR is targeting main which will trigger a production deployment when merged.

If this is a regular feature/fix PR, please change the base branch to develop.
If this is intentional (e.g., hotfix), you can ignore this warning.

Current base: main
Recommended base: develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant