Repository navigation
fix: resolve base-localized resource paths in JSON projects - #1179
Merged
pepicrft merged 3 commits intoSep 18, 2026
Merged
Conversation
ileitch
marked this pull request as ready for review
September 17, 2026 17:26
Contributor
Author
freddi-kit
approved these changes
Sep 17, 2026
freddi-kit
left a comment
Contributor
There was a problem hiding this comment.
Thank you for finding this case!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a JSON project containing a localized storyboard or XIB can make PBXVariantGroup.fullPath(sourceRoot:) return its containing directory instead of the Base resource. JSON file references omit the language name, while the existing resolver only recognizes a child named Base. Consumers filtering the returned path by resource extension silently skip the file.
For unnamed children, infer the Base variant from an exact Base.lproj directory component. Explicit Base names retain priority, and groups without a Base variant keep their existing directory fallback. The change is confined to path resolution; decoding and encoding are unchanged.
Add an on-disk JSON fixture covering a storyboard whose Base variant is not the first child, a nested XIB, and a group without Base. Tests cover direct loading, writes and reopenings in both formats, preservation of explicit Base names, and conversion of the existing iOS PBX fixture through JSON.
Validation: