Bugfixes I thought were done - #25
Merged
JedMeister merged 21 commits intoAug 5, 2026
Merged
Conversation
…exhausted file descriptors)
… included in commmand
Member
Author
|
So I've carefully combed through the code and fixed a few other bugs (some could cause major issues under specific cases) plus a couple that would only occur in unlikely edge cases (but worth fixing). For transparency I did final review with claude and it discovered the edge case bugs and suggested fixes. Hopefully that should be it for now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm almost certain there will be more, but figured might as well get you to do code review then merge now. I'll open a new PR when (if 🙏 ) I have more changes.