Skip to content

Migration: add back v5.0.0 heading - #39060

Merged
XhmikosR merged 5 commits into
mainfrom
xmr/migration
Aug 21, 2023
Merged

Migration: add back v5.0.0 heading#39060
XhmikosR merged 5 commits into
mainfrom
xmr/migration

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Aug 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR changed the title Migrations: add back v5.0.0 heading Migration: add back v5.0.0 heading Aug 15, 2023
@XhmikosR XhmikosR added the docs Documentation site and its content label Aug 15, 2023
@XhmikosR
XhmikosR marked this pull request as ready for review August 15, 2023 11:38
@XhmikosR
XhmikosR requested a review from mdo August 15, 2023 11:38
@julien-deramond

julien-deramond commented Aug 21, 2023

Copy link
Copy Markdown
Member

Good catch.
I'd say that sub-headers like "Dependencies", "Browser support", etc. should now be <h3> instead of <h2> (should be within "v5.0.0"). Now they are at the same level:
Screenshot 2023-08-21 at 08 42 09

@XhmikosR

XhmikosR commented Aug 21, 2023

Copy link
Copy Markdown
Member Author

Ah, true. I'll fix it later unless someone else can quickly make the change :)

@julien-deramond
julien-deramond self-requested a review August 21, 2023 07:11
@julien-deramond julien-deramond added the v5 v5, the v5-dev branch label Aug 21, 2023
@XhmikosR
XhmikosR merged commit 47da803 into main Aug 21, 2023
@XhmikosR
XhmikosR deleted the xmr/migration branch August 21, 2023 07:49
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@XhmikosR @romankupchak93
Migration: add back v5.0.0 heading (twbs#39060)
acc107c 
* Migrations: add back v5.0.0 heading

* Update migration.md

* Update migration.md
@RatanaSenpai RatanaSenpai mentioned this pull request May 18, 2024
Open
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
This was referenced May 19, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
@Identian Identian mentioned this pull request May 20, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 21, 2024
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 23, 2024
Open
This was referenced May 24, 2024
Open
Open
@DeFiTON DeFiTON mentioned this pull request Sep 29, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Sep 29, 2024
Open
@DeFiTON DeFiTON mentioned this pull request Sep 30, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Sep 30, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Sep 30, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 1, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 1, 2024
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 4, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Merged
This was referenced Oct 5, 2024
Open
Open
This was referenced Oct 12, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 13, 2024
Open
This was referenced Oct 15, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 20, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 22, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 27, 2024
Open
This was referenced Oct 29, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Nov 3, 2024
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes
@mdo mdo Awaiting requested review from mdo

Assignees

No one assigned

Labels

docs Documentation site and its content v5 v5, the v5-dev branch

Projects

No open projects
v5.3.2
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XhmikosR @julien-deramond