Repository navigation
fix(tooltip): preserve raw string title and content data attributes (#43090) - #43113
Merged
Merged
Conversation
julien-deramond
added
v6
Aryan9891
force-pushed
the
fix/issue-43090
branch
6 times, most recently
from
October 27, 2026 20:05
cc73e87 to
2375df2
Compare
Aryan9891
force-pushed
the
fix/issue-43090
branch
5 times, most recently
from
November 1, 2026 07:21
053a5ea to
3fa6344
Compare
…wbs#43090) Signed-off-by: Aryan Sachin <aryansachinixd@gmail.com>
Aryan9891
force-pushed
the
fix/issue-43090
branch
from
November 2, 2026 07:18
3fa6344 to
977ab7f
Compare
Cover empty and JSON-like titles, Popover rendering, explicit options, and the text and sanitized HTML boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve raw attribute strings for
data-bs-titleanddata-bs-contentinTooltip._getConfig()and fallbacknullvalues to empty strings in_configAfterMerge().Motivation & Context
Addresses #43090 where passing
data-bs-title="9.90"resulted in automatic normalization viaJSON.parseinto numeric9.9, anddata-bs-title=""was normalized tonull, causing the typecheck to throw an error and break subsequent tooltip initializations.Type of changes
Checklist
Related issues
Refs #43090. This PR fixes v6; the issue stays open for the v5 backport.