french list too broad regex filter breaking domain names with a final dot. #7619
Description
URL(s) where the issue occurs
Any domain name with a final . in the name
Describe the issue
A new regex is preventing to visit websites when the entered domain name is written with a final dot, with is legit and sometimes used by webdevs.
The offending regex is :
/^(https?|wss?):\/\/([0-9a-z\._-]+)\.(accountant|bid|cf|click|club|com|cricket|date|download|faith|fun|ga|gdn|gq|info|link|loan|men|ml|net|network|ovh|party|pro|pw|racing|review|rocks|ru|science|site|space|stream|tk|top|trade|webcam|win|xyz|zone)\.\/(.*)/$document
the problems is probably in the \.
The regex is from : FRA: EasyList Liste FR
Versions
- Browser/version: Firefox Nigthly 80
- uBlock Origin version: uBlock Origin v1.27.10
Settings
- only standard settings
Activity
mapx- commentedon Jul 2, 2020
french list issues => https://forums.lanik.us/viewforum.php?f=91
@smed79
dascritch commentedon Jul 2, 2020
Why there is no issue report howto file in the original github repo linked from the addon ?
I'm fed of, it's the third time
dascritch commentedon Jul 2, 2020
OK, I note the very offensive way to treat an issue, especially if you are not french speaking.
mapx- commentedon Jul 2, 2020
You should provide test cases , sites broken by that filter, steps to reproduce the issue
dascritch commentedon Jul 2, 2020
Easy :
google.com.is blocked.It should not, as writing a final dot in a domain name is absolutely legit.
uBlock-user commentedon Jul 2, 2020
I added
/^(https?|wss?):\/\/([0-9a-z\._-]+)\.(accountant|bid|cf|click|club|com|cricket|date|download|faith|fun|ga|gdn|gq|info|link|loan|men|ml|net|network|ovh|party|pro|pw|racing|review|rocks|ru|science|site|space|stream|tk|top|trade|webcam|win|xyz|zone)\.\/(.*)/$documentto my filters, openedgoogle.comand it works as expected. Google is not blocked.dascritch commentedon Jul 2, 2020
https://user-images.githubusercontent.com/482505/86326199-a2e47a00-bc41-11ea-827a-7c32a9cb9429.png
mapx- commentedon Jul 2, 2020
@smed79 you should remove such filters, lots of issues were reported using french list
mapx- commentedon Jul 2, 2020
@dascritch already fixed
uBlock-user commentedon Jul 2, 2020
You're going to
google.com./instead ofgoogle.com/. Why ?dascritch commentedon Jul 2, 2020
Why not ?
As I told, it is a really used trick by webdevs on websites to use many profiles on browsers. And use the Fully Qualified Domain Name notation, instead of the Relative as your usually do, may be really useful in some DNS issues.
For more details : https://webmasters.stackexchange.com/questions/73989/how-should-websites-handle-hostname-with-trailing-dot
uBlock-user commentedon Jul 2, 2020
Because
google.com./redirects togoogle.com/in the end. So not a use case.[-]Try to not block domain names with a final dot.[/-][+]french list too broad regex filter breaking domain names with a final dot.[/+]dascritch commentedon Jul 2, 2020
It was an example : numerous websites don't redirect their FQDN to their RDN , and it permits to go thru misconfigured DNS servers.
If you cannot accept tech people are using a final dot in domain names for testing purposes, you're just over complicating their job. So mine.
dascritch commentedon Jul 2, 2020
Well, even after refreshing all the caches and filters, there is too much limitations when we have
FRA: EasyList Liste FRactivated for my team : by example any JS or CSS are still blocked. As we usually use FQDN for multiple account testing on websites, I recommended to not uninstall uBlock, but to removeFRA: EasyList Liste FR.I am not able to tell which rule is blocking, as i don't have enough information in dev tools (capture of a personal website, due to NDA).
I still cannot understand why final dotted domain names are blocked, this is really problematic.
poke @uBlock-user
uBlock-user commentedon Jul 2, 2020
Did you update the uBlock unbreak list ? The RegExp filter was disabled in that list.Nevermind, all other network types are also blocked.
update #7619
gorhill commentedon Jul 2, 2020
That is such a bad generic filter that we should fix this with no question asked really -- a trailing dot is entirely valid, indiscriminately blocking any hostname which has a trailing dot is really bad. I would like to know what was the reason to add such filter in a widely used list.
dascritch commentedon Jul 2, 2020
It is really used in generic environment as it is a legal way to force a DNS request, or to make cleaned request without cookies or cleaning cache.
And it seems also used here by malicious code to circumvent a poorly written regex.
gorhill commentedon Jul 2, 2020
A trailing dot would not work around the filters which were replaced, not in uBO as far as I know, and I would be surprised other blockers would not handle properly the trailing dot, so I still fail to understand what issue this solves.
gorhill commentedon Jul 2, 2020
Ok so it appears that filter was added back then to accomodate ABP, which was not properly dealing with the trailing dot (and as a result this shortcoming was being leveraged by miners), this was eventually fixed in ABP, so that bad regex filter should be reverted back to the original set of filters or outright removed.
gorhill commentedon Jul 2, 2020
uBO drops the trailing dot, since it's essentially the same, i.e.
example.comis same asexample.com.. I don't think filters should care about the trailing dot. Missing highlighting in the logger should be fixed.Edit: I need to clarify, when I say uBO drops the trailing dot, I mean for hostname-matching purpose (which is what the original filters were), the trailing dot is not dropped in case of URL pattern-matching purpose.
Fix highligthing of FQDN match in logger
maxxyme commentedon Aug 6, 2020
Or maybe "tech people" (I am) shouldn't clutter their web browser with so much extensions when "testing"... 🤔
Fix highligthing of FQDN match in logger