Support new set-constant scriptlet values of AdGuard #2615

Activity

1. gorhill commented on Apr 27, 2023

   

   gorhill

   on Apr 27, 2023

   Member

   More actions

   I am not seeing instances of set-constant filters using these values. Can I get a sense of usage stats for these?

   👎React with 👎2Reacted by freezer2022 and drummaann
2. piquark6046 commented on Apr 27, 2023

   

   piquark6046

   on Apr 27, 2023

   Last edited by piquark6046

   MemberAuthor

   More actions

   Yep. There are some examples:

   • https://github.com/AdguardTeam/AdguardFilters/blob/b5f1b5ad14639ac7909dd2d2a7c2d00c97caf547/BaseFilter/sections/foreign.txt#L10030
   • https://github.com/AdguardTeam/AdguardFilters/blob/b5f1b5ad14639ac7909dd2d2a7c2d00c97caf547/AnnoyancesFilter/Cookies/sections/cookies_specific.txt#L10623
   • https://github.com/AdguardTeam/AdguardFilters/blob/b5f1b5ad14639ac7909dd2d2a7c2d00c97caf547/AnnoyancesFilter/Other/sections/tweaks.txt#L599
   • https://github.com/AdguardTeam/AdguardFilters/blob/b5f1b5ad14639ac7909dd2d2a7c2d00c97caf547/AnnoyancesFilter/Other/sections/tweaks.txt#L967
   • https://github.com/AdguardTeam/AdguardFilters/blob/b5f1b5ad14639ac7909dd2d2a7c2d00c97caf547/BaseFilter/sections/general_extensions.txt#L3089
3. ghost added

   enhancementNew feature or requestNew feature or request

   on Apr 27, 2023
4. gorhill commented on May 12, 2023

   

   gorhill

   on May 12, 2023

   Member

   More actions

   I want to use a different approach than AdGuard. Instead of introducing new values (noopCallbackFunc, noopPromiseResolve, etc.), I want to introduce new ways to return currently supported values. Examples:

   ...##+js(set, property, value)
   ...##+js(set, property, value, asCallback)
   ...##+js(set, property, value, asResolved)
   ...##+js(set, property, value, asRejected)
   

   • The first one behaves as expected: property is set to value
   • The second one would return a function which returns value
   • The third one returns a Promise which resolves to value
   • The fourth one returns a Promise which fails with value

   Now I need real world cases where these can be tested.

   👍React with 👍3Reacted by stephenhawk8054, Kia and Contribucious

   👎React with 👎3Reacted by freezer2022, Sukka and drummaann
5. piquark6046 commented on May 12, 2023

   

   piquark6046

   on May 12, 2023

   MemberAuthor

   More actions

   @ameshkov Please take a look.
6. ameshkov commented on May 12, 2023

   

   ameshkov

   on May 12, 2023

   More actions

   Good stuff
7. ghost added a commit that references this issue on May 17, 2023

   Render List stats below on mobile

   9ea3988
9. gorhill

   added a commit that references this issue on May 19, 2023

   Expand/harden some scriptlets

   ...

   2ef2888
10. uBlock-user

    closed this as completedon Jun 4, 2023
11. uBlock-user

    added

    fixedissue has been addressedissue has been addressed

    on Jun 4, 2023
12. stephenhawk8054

    added a commit that references this issue on Jul 26, 2023

    filmweb.pl GDPR dialog

    9108057
13. stephenhawk8054 commented on Jul 1, 2024

    

    stephenhawk8054

    on Jul 1, 2024

    Last edited by stephenhawk8054

    Member

    More actions

    @gorhill I just realized I don't see the options as (asCallback, asResolved...) in the current code: https://github.com/gorhill/uBlock/blob/master/assets/resources/scriptlets.js . Were they not transferred when switching to vararg approach?
14. garry-ut99 commented on Jul 1, 2024

    

    garry-ut99

    on Jul 1, 2024 · Hidden as abuse

    Last edited by garry-ut99

    show commentMore actions
15. mneunomne

    added a commit that references this issue on Jul 16, 2026

    Expand/harden some scriptlets

    ...

    d8ed9ea