Skip to content

Sort hostnameSwitchesString and netWhitelist consistently when backing up settings #969

Open

Description

@assarbad

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Some of the above don't seem to be applicable to a feature request.

Description

I have a feature request, which I hope is "cheap" to implement.

The contents of hostnameSwitchesString and netWhitelist don't seem to be sorted consistently when exporting settings across browsers. The same is true for the list selectedFilterLists.

While the (newer) version on Firefox also contains some keys not present in the (older) version on Vivaldi, it would be helpful if the list contained in those values were sorted (it would make it easier to place the backups under version control and compare them).

If possible - but I figure that this may actually be really hard to do - it would be also great if the key names were also sorted.

Thanks for uBlock Origin and thanks for reading.

Your environment

  • uBlock Origin version: v1.25.2 (in Firefox) / v1.24.4 (in Vivaldi) ... no idea why they are a different version, there don't seem to be updates available, though
  • Browser Name and version: Firefox 74.0 / Vivaldi 2.11.1811.49
  • Operating System and version: Ubuntu 18.04.4

Activity

  1. changed the title [-][feature request] Sort hostnameSwitchesString and netWhitelist consistently when backing up settings[/-] [+]Sort hostnameSwitchesString and netWhitelist consistently when backing up settings[/+] on Mar 30, 2020
  2. assarbad commented on Apr 8, 2020

    @assarbad
    Author

    Do you have a Wiki where I could get started about contributing? If I find the time I'll be happy to send a pull request. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions