Repository navigation
fix(changeprovider): validate GitHub head on every page - #828
Open
Tmwakalasya wants to merge 4 commits into
Open
Tmwakalasya wants to merge 4 commits into
Tmwakalasya wants to merge 4 commits into
Conversation
Tmwakalasya
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 8, 2026 20:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
If a PR's head changes between GraphQL file pages, the provider can return files from different revisions under the originally submitted SHA. It retains the first page's head and validates only after collecting every page, so a different head on a later page goes unnoticed.
What?
Move the existing staleness check into the pagination loop, before appending each page's files. Every page must match the SHA in the submitted change URI; a mismatch returns an error immediately without returning partial change information.
Add table-driven regression tests for stale heads on the first, middle, and final pages, including stopping before any subsequent page is requested. The existing successful-pagination test remains the control.
Test Plan
./tool/bazel test //submitqueue/extension/changeprovider/github:go_default_test --nofetch --test_output=errors.go vet -mod=readonly ./submitqueue/extension/changeprovider/github.make fmt lint check-tidy check-gazelleandgit diff --cached --check.Issue
No linked issue.