Polish dimensionality demo unit assignment#268
Merged
lmoresi merged 1 commit intoJun 24, 2026
Merged
Conversation
lmoresi
approved these changes
Jun 24, 2026
lmoresi
left a comment
Member
There was a problem hiding this comment.
This is exactly the polish I suggested on #261 — .array[...] = uw.quantity(value, unit) dimensional assignment instead of manual scaling, plus the .array (dimensional) vs .data (ND) explanation. Verified it runs end-to-end (✅ Dimensional analysis complete). The demo now actually showcases the units interface. Thanks @ss2098!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up to #261 updates docs/examples/Dimensionality-Demo.py to use the public unit-aware .array interface for dimensional assignment.
The previous fix made the demo run by manually writing non-dimensional values into .data. This polish assigns dimensional quantities through .array, for example:
T.array[...] = uw.quantity(1300.0, "kelvin")
and then shows that .data contains the corresponding non-dimensional internal storage.
This better demonstrates the intended units interface:
No solver behavior is changed.
Tested with:
pixi run python docs/examples/Dimensionality-Demo.py
Result: script completes successfully.