chore: pin the linters and run the sidecar spec in ci - #41
Merged
Conversation
luacheck pins its interpreter too: 1.2.0 will not load on lua 5.5.
the lua-test job had no go toolchain, so the spec skipped on every pr.
release.yml tags but cannot push the rename back. v0.1.30 is closed off here.
the go tests fake at the RoundTripper boundary, so a query github would refuse passes them.
get_file_versions fetches base and head concurrently, so -race caught the increment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go-testruns under-race; the sidecar is a goroutine per request over a shared client and cache.tools, and ci runs the make targets rather than marketplace actions. luacheck pins its interpreter too: 1.2.0 will not load on lua 5.5.golangci.ymlnames the v2 defaults, and stops golangci-lint walking up into a parent's configlua-test-nvimbuilds the sidecar, sosidecar_specruns rather than skipping as it has on every pr since it was writtenvim.uv.new_timerget_pending_reviewshipped broken in every release-raceleg on its first full run:Differopens, and the merge-tool reroutelua-test (v0.12.0)andgql-validateadded to main's required checksTest plan
make check: unit 370/0, headless-nvim 444/0 with 0 pending, luacheck 0, golangci-lint 0, lua_ls clean, demo-build ok, go ok under-racemake gql-validate: 21 documents accepted, and it fails on the reinstatedget_pending_reviewbugsidecar_specfails in 0.003s with no binary[Unreleased].toolsfetch of all four tools, each guard failing on a bad pin-race, plus 3 fullgo test -race ./...make vimdocregenerates doc/differ.txt unchanged