Repository navigation
fix: web lazy components not hot reloading css - #646
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR patches Metro lazy development graphs to include Uniwind’s configured CSS entry, allowing CSS changes used by lazy web components to participate in graph traversal and hot reload.
Confidence Score: 4/5The PR appears safe to merge for normal single-config Metro processes, with a non-blocking stale-path issue when multiple configurations are initialized in one process. The lazy-graph behavior is correctly installed for the first configuration, but the process-wide wrapper captures that configuration’s CSS path and silently ignores later paths. Files Needing Attention: packages/uniwind/src/bundler/adapters/metro/patches.ts
|
| Filename | Overview |
|---|---|
| packages/uniwind/src/bundler/adapters/metro/metro.ts | Installs the lazy-graph patch with the configured CSS entry path during Metro adapter setup. |
| packages/uniwind/src/bundler/adapters/metro/patches.ts | Adds CSS to lazy development graphs, but its one-time global wrapper retains the first configuration’s path. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[withUniwindConfig] --> B[Resolve configured CSS entry]
B --> C[Patch Metro Graph prototype]
C --> D{Lazy development graph?}
D -- Yes --> E[Add CSS entry to graph entryPoints]
D -- No --> F[Keep original entry points]
E --> G[Run original initial traversal]
F --> G
G --> H[CSS participates in updates]
Reviews (1): Last reviewed commit: "fix: web lazy components not hot reloadi..." | Re-trigger Greptile
|
🚀 This pull request is included in v1.12.0. See Release v1.12.0 for release notes. |
#642
Summary by CodeRabbit