Skip to content

ICU-22902 Remove support for Unsupported, Private & Reserved constructs - #3193

Merged
catamorphism merged 1 commit into
unicode-org:mainfrom
catamorphism:icu-22902-remove-reserved
Sep 21, 2024
Merged

ICU-22902 Remove support for Unsupported, Private & Reserved constructs#3193
catamorphism merged 1 commit into
unicode-org:mainfrom
catamorphism:icu-22902-remove-reserved

Conversation

@catamorphism

@catamorphism catamorphism commented Sep 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Corresponds to unicode-org/message-format-wg#883

Also move spec tests for unsupported statements and expressions into new files to serve as syntax error tests.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22902
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

mihnita
mihnita previously approved these changes Sep 20, 2024
View reviewed changes

@mihnita mihnita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you,
Mihai

echeran
echeran previously approved these changes Sep 20, 2024
View reviewed changes

@echeran echeran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread icu4c/source/i18n/messageformat2_data_model.cpp Outdated
@catamorphism
catamorphism dismissed stale reviews from echeran and mihnita via 636f06a September 20, 2024 23:33
@catamorphism
catamorphism force-pushed the icu-22902-remove-reserved branch from c0f4b69 to 636f06a Compare September 20, 2024 23:33
@jira-pull-request-webhook

jira-pull-request-webhook Bot commented Sep 20, 2024

Copy link
Copy Markdown

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/messageformat2_parser.cpp is different
  • icu4c/source/i18n/messageformat2_parser.h is different
  • icu4c/source/i18n/messageformat2_serializer.cpp is different
  • icu4c/source/test/intltest/messageformat2test_read_json.cpp is different
  • icu4j/main/core/src/test/java/com/ibm/icu/dev/test/message2/CoreTest.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@catamorphism

catamorphism commented Sep 20, 2024

Copy link
Copy Markdown
Contributor Author

I ended up having to rebase this due to #3092 landing first, so if @mihnita or @echeran can reapprove, I can land it.

@catamorphism
catamorphism force-pushed the icu-22902-remove-reserved branch from 636f06a to 13a636f Compare September 20, 2024 23:35
@jira-pull-request-webhook

jira-pull-request-webhook Bot commented Sep 20, 2024

Copy link
Copy Markdown

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/messageformat2_parser.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@catamorphism
ICU-22902 Remove support for Unsupported, Private & Reserved constructs
78f1594 
Matching PR unicode-org#883 in the message-format-wg repo.

Also move spec tests for unsupported statements and expressions into new files
to serve as syntax error tests.
@catamorphism
catamorphism force-pushed the icu-22902-remove-reserved branch from 13a636f to 78f1594 Compare September 20, 2024 23:44
@jira-pull-request-webhook

jira-pull-request-webhook Bot commented Sep 20, 2024

Copy link
Copy Markdown

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/messageformat2_data_model.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

mihnita
mihnita approved these changes Sep 20, 2024
View reviewed changes

@mihnita mihnita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you,
M.

@catamorphism
catamorphism merged commit 2f348f4 into unicode-org:main Sep 21, 2024
@catamorphism catamorphism mentioned this pull request Sep 24, 2024
Merged
7 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihnita mihnita mihnita approved these changes
@echeran echeran Awaiting requested review from echeran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@catamorphism @echeran @mihnita