Repository navigation
unsloth: pin ggml-org#25731 directly and retire the Inkling carry - #140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Inkling pin from the
#138carry toggml-org#25731directly, and retires the last fork carry in the set. After this the pin set has none: every entry is either an upstream PR or a fork PR that carries fork-only work.#138existed becauseggml-org#25731did not merge onto a base tag containing the qwen4exp squash. danielhanchen#3 landed that same resolution onadd-inklingasedee0e16, so25731ismergeableagain and the carry has nothing left to add.This is a provable no-op
Identical trees, and
2e9d6fb2is an ancestor ofedee0e16.Replaying the full chain onto
b10665with the new pin substituted gives the same six merges, the same singleadditive_merge.pyresolution ontools/mtmd/CMakeLists.txt, and a final merged tree ofeb067b53b35b5dcc8dce7eed6a8554e506015507, byte-identical to the tree the current pin set produces. Nothing about the build changes.edee0e16is a commit ofggml-org#25731(pin-membership gate)refs/pins/edee0e160ae0a8004dc9205a4197ba6ea3686500before this PR was opened, so the pin stays fetchable even though25731is a draft on a personal fork whose head can move#138is closed once this merges. Its branchinkling-25731-b10665and the base branch stay in place.