Repository navigation
pr-set: pin EmbeddingGemma-2 support - #248
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26d1568fef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "https://github.com/unslothai/llama.cpp/pull/241/commits/b96a713a48313a32c92fd6f77b367ea9d803417b", | ||
| "https://github.com/unslothai/llama.cpp/pull/243/commits/aba4a4c1db96d56846e86d1169dd35241bafd55d" | ||
| "https://github.com/unslothai/llama.cpp/pull/243/commits/aba4a4c1db96d56846e86d1169dd35241bafd55d", | ||
| "https://github.com/unslothai/llama.cpp/pull/247/commits/73c2f733e8beef7dd104de747442eb9e21f2bb96" |
There was a problem hiding this comment.
Register #247 in the feature coverage manifest
Adding this pin makes the “Every pin is either checked or knowingly unchecked” step in .github/workflows/unsloth-pr-set-lint.yml derive unslothai#247 and require that key in either features or unchecked in scripts/unsloth/feature-checks.json. This commit adds neither, so every push or pull-request validation triggered by this file exits nonzero with unslothai#247 is pinned and appears in neither features nor unchecked; add an appropriate architecture check or a documented unchecked entry.
Useful? React with 👍 / 👎.
Summary
Adds #247 (EmbeddingGemma-2 support, by @ngxson) to
scripts/unsloth/pr-set.json, after #243. #243 stays pinned at its current head,aba4a4c1db96.Testing
Local mirror of
unsloth-pin-preflight.yml, on baseb11436(newest aged upstream release):additive_merge.py, the rest merge cleanlymerge_checks.pypin_contract.pyscripts/unsloth/test_*.pyThe merged tree builds
llama-embeddingandllama-server. On the BF16 GGUF its embedding is bit-identical to a build of the upstream EmbeddingGemma-2 change.