Skip to content

pr-set: pin EmbeddingGemma-2 support - #248

Merged
danielhanchen merged 1 commit into
masterfrom
pin-embeddinggemma-2
Oct 6, 2026
Merged

danielhanchen merged 1 commit into
masterfrom
pin-embeddinggemma-2

Conversation

@danielhanchen

Copy link
Copy Markdown
Member

Summary

Adds #247 (EmbeddingGemma-2 support, by @ngxson) to scripts/unsloth/pr-set.json, after #243. #243 stays pinned at its current head, aba4a4c1db96.

Testing

Local mirror of unsloth-pin-preflight.yml, on base b11436 (newest aged upstream release):

Check Result
Pin merges all 15 pins merge in order. ggml-org#25731, #70 and #247 go through additive_merge.py, the rest merge cleanly
merge_checks.py clean (23 python, 192 c++ files)
pin_contract.py all 15 pins intact. #247: 5 files with new symbols, 213 lines accounted for
scripts/unsloth/test_*.py all 9 pass

The merged tree builds llama-embedding and llama-server. On the BF16 GGUF its embedding is bit-identical to a build of the upstream EmbeddingGemma-2 change.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T16:04:40.416281Z 26d1568 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@danielhanchen
danielhanchen merged commit 6bd1192 into master Oct 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26d1568fef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"https://github.com/unslothai/llama.cpp/pull/241/commits/b96a713a48313a32c92fd6f77b367ea9d803417b",
"https://github.com/unslothai/llama.cpp/pull/243/commits/aba4a4c1db96d56846e86d1169dd35241bafd55d"
"https://github.com/unslothai/llama.cpp/pull/243/commits/aba4a4c1db96d56846e86d1169dd35241bafd55d",
"https://github.com/unslothai/llama.cpp/pull/247/commits/73c2f733e8beef7dd104de747442eb9e21f2bb96"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Register #247 in the feature coverage manifest

Adding this pin makes the “Every pin is either checked or knowingly unchecked” step in .github/workflows/unsloth-pr-set-lint.yml derive unslothai#247 and require that key in either features or unchecked in scripts/unsloth/feature-checks.json. This commit adds neither, so every push or pull-request validation triggered by this file exits nonzero with unslothai#247 is pinned and appears in neither features nor unchecked; add an appropriate architecture check or a documented unchecked entry.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant