Repository navigation
CI: drop stray upstream workflows and waive the deliberate metadata deletions in the sync guard - #275
Merged
Merged
Conversation
…ve the deliberate metadata deletions in the sync guard release-publish.yml (upstream 'Publish Release', workflow_run on 'Release', a workflow master does not have), models-check.yml and the seven ci-self-hosted-*.yml came in with the 2026-10-06 sync. The fork owns no upstream CI (sync_deletes.py policy), the repo has no self-hosted runners, so the self-hosted ones only ever sat queued until cancelled, and release-publish.yml failed check_workflow_triggers.py, which turned both unsloth-pr-set-lint and the upstream sync guard red on every push and PR. The sync guard's 'fork owns only CI' step also failed on master because AGENTS.md, CLAUDE.md and CODEOWNERS were deleted on purpose (8700cfd, 4f39f57, 43b49fa). upstream-sync.json now lists them in removed_ok; only a removal is waived, an edit to any of them still fails.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
danielhanchen
added a commit
that referenced
this pull request
Oct 14, 2026
danielhanchen
added a commit
that referenced
this pull request
Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two Unsloth guards have been red on master since the b11436 sync (2026-10-06):
Unsloth: lint pr-set.json(27 of 40 runs failed, 17 of 19 pushes):check_workflow_triggers.pystops onrelease-publish.yml: RESTRICTED trigger 'workflow_run' has no '# lint:workflow_triggers-allow-workflow_run' comment.Unsloth: upstream sync guard(33 of 33 failed): the same trigger check fails its last step on every PR, and on master the "fork still owns only CI" step reportsAGENTS.md,CLAUDE.mdandCODEOWNERSas divergence.Both come from the sync, not from fork work:
release-publish.yml,models-check.ymland the sevenci-self-hosted-*.ymlare upstream workflows added between 09-21 and 10-04. The fork owns no upstream CI (the policysync_deletes.pyenforces), but these were not deleted.release-publish.ymlfires onworkflow_runof a workflow namedRelease, which master does not have, so it can never run. It only fails the lint.Change
release-publish.yml,models-check.ymlandci-self-hosted-{cpu,cuda,kleidiai,metal,openvino,vulkan,webgpu}.ymlfrom master.sync_deletes.pykeeps these deletions on later syncs (modify/delete conflicts on upstream workflows resolve to the deletion).upstream-sync.json: newremoved_oklist (AGENTS.md,CLAUDE.md,CODEOWNERS), documented in_doc.unsloth-upstream-sync-guard.yml: a path inremoved_okis waived only while its compare status isremoved. If one of them comes back with fork edits it fails like any other source divergence. Every other path is checked as before.No Unsloth workflow, prebuilt job or
pr-set.jsoncheck depends on the deleted files. Theunsloth-*workflows reference only each other (workflow_runonUnsloth prebuilt (full release)andUnsloth pin preflight).Tests
check_workflow_triggers.py: exits 1 on master's tree with therelease-publish.ymlerror above, and exits 0 with this change (14 workflow(s): no pull_request_target, no unjustified workflow_run).check_workflow_scalars.pyandcheck_workflow_outputs.pyexit 0.test_additive_merge,test_pin_merge,test_merge_checks,test_sync_deletes,test_carry_vintage,test_pin_contract,test_feature_matrix,test_check_workflow_triggers), plustest_verify_upstream_sync: all pass.compare/b9a5a00b8...master(103 files):AGENTS.md,CLAUDE.md,CODEOWNERS;CODEOWNERSmodifiedentry and asrc/x.cppremovedentry, the new filter reports both, so only the listed deletions are waived.