Repository navigation
pr-set: repin #264 and #266, drop ggml-org#30670 (merged upstream) - #286
Open
danielhanchen wants to merge 1 commit into
Open
danielhanchen wants to merge 1 commit into
danielhanchen wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The prebuilt is upstream ggml-org at an aged
b####tag plus the pins inscripts/unsloth/pr-set.json, merged in order. This updates the pin set so the scheduled build merges again:01fc3aae8), already in the aged base. Pinning it again is the same change twice, whichadditive_merge.pyrefuses. This is what failed the 10-17 nightly (run 39066439326):refused common/parsers/parsers.h ... src/llama-arch.cpp: both sides add the same line(s).5bb68456b->194170f8cmul_mat_idtests that upstream ggml-org#30501 disabled with#if 0; the pin branch now mergesb11627(the oldest tag with ggml-org#30501), keeps upstream's#if 0block verbatim and keeps only the pin's IQ1_M type inside it. PR base retargeted tobase/upstream-8c2134a87.88035b0f7->1eae0b577feature-checks.json: thebeamentry keeps its check withowner: null, since the feature now arrives through the base tag.Evidence
llama_pinset.py audit --pr-set: 17/17 pins clean, feature-checks coverage ok.Not covered here
ROCm, Vulkan, macOS, Windows and ARM legs only run in the nightly. Tags newer than b11718 were not simulated.