Repository navigation
pr-set: pin #298 (DeepSeek-V4.1-Flash-1017 full stack, after #61) - #299
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds #298 (DeepSeek-V4.1-Flash-1017: model, MXFP8 type, runtime, chat parser, perf, DSpark draft, vision; everything from #289 to #297 except #292) to the nightly pin set, pinned at
9d907b7.How the prebuilt uses this: release = an aged upstream ggml-org
b####tag plus the pins inscripts/unsloth/pr-set.json, merged in order (git merge, thenadditive_merge.pyfor pure add/add conflicts only). Nothing is carried in forkmaster; once upstream takes the model, the pin is deleted.Ordering and the #61 base
#61 (IQ1_XS / IQ1_XXS / IQ1_XXXS, types 64..66) and #298 (MXFP8, type 43) both add a
ggml_typeand both editGGML_TYPE_COUNT = 43,, whichadditive_merge.pycorrectly refuses. #298 is therefore based ondsv41-pin-base61b(the pinned #61 commit05a6693plus upstream797de63b2) and carries the combined enum (MXFP8 = 43,IQ1_XS..IQ1_XXXS = 64..66,GGML_TYPE_COUNT = 67). It must stay after #61 in this list. MXFP8 stays at 43 because the published DeepSeek-V4.1 GGUFs store the n-gram table as type 43.llama_pinset.py auditflags this as a FIX row (base carries #61's source files, so the pin's own change counts #61 as well). That is the stacking above, not a stale base. If #61 is ever re-pinned or dropped, #298 has to be updated with it.Feature checks
New
deepseek41entry owned byunslothai#298:archdeepseek41(test-llama-archs)backend-opGET_ROWSwithtype=mxfp8(MXFP8 is gather-only)mtmdprojectordeepseek41vEvidence
llama_pinset.py simwith thispr-set.json, window of tags:pin_contract for #298: 46 files with new symbols, 4462 lines accounted for, on every tag.
audit: feature-checks coverage ok. Pre-existing FIX rows for #264 and #266 (pin != PR head) are unrelated to this change.verify --tag aged --cuda(b11724) andverify --tag newest --cuda(b11729), same result on both:feature_matrix --only deepseek41 --gpuon the b11729 merged tree: 3/3 device rows decoded and matched CPU, 9/9 MXFP8 GET_ROWS cases matched the CPU reference, projector registry intact over 221 assertions.