Repository navigation
pr-set: repin Inkling for the Vulkan GGML_PREC_F32_PEDANTIC switch - #324
Merged
Merged
Conversation
…src1 precision switch
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repins Inkling (ggml-org#25731) from b49c8ba to 48ad1d8.
The b11871 prebuilt run (40213734709) failed on
CPU / linux/arm64 + Vulkan:Inkling adds
GGML_PREC_F32_PEDANTICand handled it inggml_vk_prec_allows_f16acc, but not inggml_vk_src1_prec_allows_q8. 48ad1d8 adds it to thereturn falsegroup (an F32-pedantic src1 must not be quantized to Q8), which is the only change.Checks:
-Wswitch -Werror: the old head fails with the same error, the new head passes. No other switch overggml_precin the tree lacks the new value.llama_pinset.py sim --pin b49c8ba=48ad1d8: b11871 and b11873 merge clean, pin_contract and merge_checks pass, and the merged tree carries the new case.Not covered here: b11887 (newest) refuses #61, #264, #298 and #304 on
ggml-cuda/mmq.cu*, which is independent of this repin and needs its own fix before the nightly ages onto it.