Skip to content

test: cover Run-with-no-arguments paths (#2406) #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dearchap merged 1 commit into from
Aug 16, 2026
Merged

test: cover Run-with-no-arguments paths (#2406) #2407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6452,15 +6452,19 @@ func TestCommand_Walk_NilFn(t *testing.T) {
}

// TestRunWithNoOsArgs checks that Run does not panic when handed an empty
// argument slice.
// argument slice. In particular, the combination of an empty Name and
// EnableShellCompletion exercises both the setupDefaults empty-name guard
// and the buildCompletionCommand("") append together.
func TestRunWithNoOsArgs(t *testing.T) {
for _, tst := range []struct {
name string
cmd *Command
name string
cmd *Command
wantName string
}{
{name: "plain", cmd: &Command{Name: "foo"}},
{name: "shell completion enabled", cmd: &Command{Name: "foo", EnableShellCompletion: true}},
{name: "plain", cmd: &Command{Name: "foo"}, wantName: "foo"},
{name: "shell completion enabled", cmd: &Command{Name: "foo", EnableShellCompletion: true}, wantName: "foo"},
{name: "no name", cmd: &Command{}},
{name: "no name, shell completion enabled", cmd: &Command{EnableShellCompletion: true}},
} {
t.Run(tst.name, func(t *testing.T) {
called := false
Expand All @@ -6473,6 +6477,7 @@ func TestRunWithNoOsArgs(t *testing.T) {
require.NoError(t, tst.cmd.Run(buildTestContext(t), []string{}))
})
assert.True(t, called)
assert.Equal(t, tst.wantName, tst.cmd.Name)
})
}
}