fix: secure self-hosted registration#419
Draft
KMKoushik wants to merge 2 commits into
Draft
Conversation
Entire-Checkpoint: ffd86f2fc074
Entire-Checkpoint: 6ca49fe34a6f
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying usesend with
|
| Latest commit: |
9393d13
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://26b8012f.usesend.pages.dev |
| Branch Preview URL: | https://agent-secure-self-hosted-reg.usesend.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Self-hosted deployments currently allow any reachable user to create an account, bypass the cloud waitlist, and pass instance-wide admin authorization. Invite links also do not verify that the authenticated user's email matches the invitation.
Impact
Fresh installations bootstrap with one instance administrator. Existing users continue to sign in normally. New users on initialized self-hosted installations must have a matching, unexpired invitation.
The migration adds
User.isInstanceAdminandTeamInvite.expiresAt. Existing installations promote the oldest team administrator, falling back to the oldest user when team setup is incomplete.Verification
AppSideBar.tsxandtrpc.tsgit diff --checkpassedNo database migration was executed locally.